From 7d35aea046986747911ac3063bb738647a2d3a97 Mon Sep 17 00:00:00 2001 From: Benaka Date: Sun, 3 Dec 2017 02:32:15 -0800 Subject: Several fixes/improvements to angular period selector (#12319) * If a period is filtered out, the result of the periods array becomes an object which breaks the period selector which expects an array. * Use $onInit instead of directive constructor. Seems angular.js silences errors when this is done. * Parse previousN/lastN dates correctly in angular periods service. * Parse periods using piwikPeriods client side, since we cannot assume a date range. Also if an invalid is used for period/date, display ERROR in the period selector. * Angular will swallow errors from datepicker.parseDate, so add a console.log for developer sanity + make sure period selector has consistent state even when period/date values are invalid (& result in failed date parsing). * Update misc/log-analytics submodule to latest. --- misc/log-analytics | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'misc') diff --git a/misc/log-analytics b/misc/log-analytics index cdb7c3981e..05a5154712 160000 --- a/misc/log-analytics +++ b/misc/log-analytics @@ -1 +1 @@ -Subproject commit cdb7c3981e0af52ce9666a5721c52a28f16cf963 +Subproject commit 05a5154712fd9324f31422cace1555693ef3934c -- cgit v1.2.3