From 8bc18861652ddcd64f8022318f0b8201ac7e9ba4 Mon Sep 17 00:00:00 2001 From: diosmosis Date: Tue, 6 Aug 2019 14:16:13 -0700 Subject: Handle ranking query others row properly in contents & events archiver. (#14622) * Add more types of actions to ManyVisitsWithMockLocationProvider fixture. * fix test change * update expected test files * Handle ranking query others row properly in contents & events archiver. * Use custom ranking query specific others label and handle by default in DataArray::asDatatable(). * Updating expected test files. * Use strict compare since label can be 0 apparently. * Update expecred test files. --- plugins/Contents/Archiver.php | 2 -- 1 file changed, 2 deletions(-) (limited to 'plugins/Contents/Archiver.php') diff --git a/plugins/Contents/Archiver.php b/plugins/Contents/Archiver.php index 27ead44c37..a627ac38d8 100644 --- a/plugins/Contents/Archiver.php +++ b/plugins/Contents/Archiver.php @@ -117,7 +117,6 @@ class Archiver extends \Piwik\Plugin\Archiver $rankingQuery = null; if ($rankingQueryLimit > 0) { $rankingQuery = new RankingQuery($rankingQueryLimit); - $rankingQuery->setOthersLabel(DataTable::LABEL_SUMMARY_ROW); $rankingQuery->addLabelColumn(array('contentPiece', 'contentTarget', 'contentName')); $rankingQuery->addColumn(array(Metrics::INDEX_NB_UNIQ_VISITORS)); $rankingQuery->addColumn(array(Metrics::INDEX_CONTENT_NB_IMPRESSIONS, Metrics::INDEX_NB_VISITS), 'sum'); @@ -173,7 +172,6 @@ class Archiver extends \Piwik\Plugin\Archiver $rankingQuery = null; if ($rankingQueryLimit > 0) { $rankingQuery = new RankingQuery($rankingQueryLimit); - $rankingQuery->setOthersLabel(DataTable::LABEL_SUMMARY_ROW); $rankingQuery->addLabelColumn(array('contentPiece', 'contentInteraction', 'contentName')); $rankingQuery->addColumn(array(Metrics::INDEX_CONTENT_NB_INTERACTIONS), 'sum'); } -- cgit v1.2.3