From 871c31d0962a144b85ca2601a24b9d10ab707bfc Mon Sep 17 00:00:00 2001
From: Thomas Steur <tsteur@users.noreply.github.com>
Date: Fri, 24 May 2019 23:18:03 +0200
Subject: Changed period in row evolution breaks graph/metric association
 (#14423)

* Changed period in row evolution breaks graph/metric association

fix #14208

worked for me, also with multi row evolution. Only known issue I found is if requesting eg first yearly row evolution which may have the `users` metric hidden, then switching to `day` period, and then the `users` metric is maybe supposed to become available but didn't. That should be quite edge case though.

* add class whether row is hidden

* Fixing couple regressions visible in ui tests.

* fix build + update comment

* tweak

* test tweak
---
 plugins/CoreHome/templates/getMultiRowEvolutionPopover.twig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'plugins/CoreHome/templates')

diff --git a/plugins/CoreHome/templates/getMultiRowEvolutionPopover.twig b/plugins/CoreHome/templates/getMultiRowEvolutionPopover.twig
index ec6d8b82c5..90d0a9aaf9 100644
--- a/plugins/CoreHome/templates/getMultiRowEvolutionPopover.twig
+++ b/plugins/CoreHome/templates/getMultiRowEvolutionPopover.twig
@@ -8,7 +8,7 @@
         <h2>{{ availableRecordsText|translate }}</h2>
         <table class="metrics" border="0" cellpadding="0" cellspacing="0">
             {% for i, metric in metrics %}
-                <tr {% if metric.hide|default %}style="display:none"{% endif %}>
+                <tr {% if metric.hide|default %}class="hiddenByDefault" style="display:none"{% endif %}>
                     <td class="sparkline">
                         {{ metric.sparkline|raw }}
                     </td>
-- 
cgit v1.2.3