From 212a3346a0ca3441b63f20d361ad4c9369661114 Mon Sep 17 00:00:00 2001 From: dizzy Date: Sun, 27 Mar 2022 15:23:27 -0700 Subject: [Vue] migrate PiwikMarketplaceController, piwik-marketplace directive and piwik-plugin-name directive (#18966) * start migration * finish migrating license key * get UI test to pass locally * remove angularjs file * remove todo * migrate PiwikMarketplaceController to vue * apply review feedback * unfinished commit * migrate piwik-plugin-name directive, add types for dotdotdot, remove use of $location in broadcast.updatePopoverParamValue, add ability to reference vue directives in twig (for migrating twig code in the future) * remove directive use * try to fix random failure * remove file from plugin php * fix url update * fix more URL changing issues. allow "query" to be obtained from GET as well as POST params so marketplace reporting page does not have to redirect to admin page when searching * reapply vue directives to dotdotdot --- plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'plugins/CustomDimensions') diff --git a/plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js b/plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js index b0ce39ee23..8aacff253d 100644 --- a/plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js +++ b/plugins/CustomDimensions/tests/UI/CustomDimensions_spec.js @@ -175,9 +175,9 @@ describe("CustomDimensions", function () { await page.goto(reportUrlDimension3); await (await page.jQuery('.dataTable .subDataTable .value:contains(en):first')).click(); await page.waitForNetworkIdle(); - await page.waitForTimeout(100); - await (await page.jQuery('td.label:contains(en_US)')).hover(); - await page.waitForTimeout(100); + await page.waitForTimeout(200); + await (await page.jQuery('td.label:contains(en_US):visible')).hover(); + await page.waitForTimeout(200); await triggerRowAction('en_US', 'actionTransitions'); }); }); -- cgit v1.2.3