From 2615404eab2e96048583caccf86248af2dd90d9b Mon Sep 17 00:00:00 2001 From: Benaka Moorthi Date: Sun, 4 Aug 2013 18:46:23 -0400 Subject: Refs #4040, #4041, move visualization only view properties to separate visualizations, changed JavaScript properties to 'client side parameters' and 'overridable properties' to 'client side properties', changed keep_summary_row from a JavaScript property to a client side property, allowed visualization properties to be inherited, fixed system that allowed visualizations to set custom defaults for property values, modified behavior of datatable_css_class viewdatatable property, allow view properties to be customized in metadata based on the visualization used, and tweaks to UI Integration tests. --- plugins/DBStats/DBStats.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'plugins/DBStats/DBStats.php') diff --git a/plugins/DBStats/DBStats.php b/plugins/DBStats/DBStats.php index def12d84a4..8cbbeaa961 100644 --- a/plugins/DBStats/DBStats.php +++ b/plugins/DBStats/DBStats.php @@ -105,7 +105,7 @@ class Piwik_DBStats extends Plugin $result['show_offset_information'] = false; $result['show_pagination_control'] = false; - $result['show_all_ticks'] = true; + $result['visualization_properties']['JqplotGraph']['show_all_ticks'] = true; // translate the labels themselves $valueToTranslationStr = array( @@ -256,7 +256,7 @@ class Piwik_DBStats extends Plugin $properties['show_tag_cloud'] = false; $properties['show_table_all_columns'] = false; $properties['keep_summary_row'] = true; - $properties['disable_row_evolution'] = true; + $properties['visualization_properties']['HtmlTable']['disable_row_evolution'] = true; $properties['translations'] = array( 'label' => Piwik_Translate('DBStats_Table'), 'year' => Piwik_Translate('CoreHome_PeriodYear'), -- cgit v1.2.3 From 9b5a42a62395607556893085701a8d385c464697 Mon Sep 17 00:00:00 2001 From: Benaka Moorthi Date: Sun, 4 Aug 2013 19:05:21 -0400 Subject: Refs #4040, #4041, change the way jqplot.js checks for viewdatatble types, changed relatedReports view property name to related_reports and fixed spelling of row_picker_mach_rows_by. --- plugins/DBStats/DBStats.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'plugins/DBStats/DBStats.php') diff --git a/plugins/DBStats/DBStats.php b/plugins/DBStats/DBStats.php index 8cbbeaa961..593f2a9b64 100644 --- a/plugins/DBStats/DBStats.php +++ b/plugins/DBStats/DBStats.php @@ -146,7 +146,7 @@ class Piwik_DBStats extends Plugin $this->addPresentationFilters($result); $result['title'] = Piwik_Translate('DBStats_MetricTables'); - $result['relatedReports'] = array( + $result['related_reports'] = array( 'DBStats.getMetricDataSummaryByYear' => Piwik_Translate('DBStats_MetricDataByYear') ); @@ -161,7 +161,7 @@ class Piwik_DBStats extends Plugin $result['translations']['label'] = Piwik_Translate('CoreHome_PeriodYear'); $result['title'] = Piwik_Translate('DBStats_MetricDataByYear'); - $result['relatedReports'] = array( + $result['related_reports'] = array( 'DBStats.getMetricDataSummary' => Piwik_Translate('DBStats_MetricTables') ); @@ -175,7 +175,7 @@ class Piwik_DBStats extends Plugin $this->addPresentationFilters($result); $result['title'] = Piwik_Translate('DBStats_ReportTables'); - $result['relatedReports'] = array( + $result['related_reports'] = array( 'DBStats.getReportDataSummaryByYear' => Piwik_Translate('DBStats_ReportDataByYear') ); @@ -190,7 +190,7 @@ class Piwik_DBStats extends Plugin $result['translations']['label'] = Piwik_Translate('CoreHome_PeriodYear'); $result['title'] = Piwik_Translate('DBStats_ReportDataByYear'); - $result['relatedReports'] = array( + $result['related_reports'] = array( 'DBStats.getReportDataSummary' => Piwik_Translate('DBStats_ReportTables') ); -- cgit v1.2.3 From 1d09b2cbe273035c92b15f9e4b96aa88419cda81 Mon Sep 17 00:00:00 2001 From: Benaka Moorthi Date: Wed, 7 Aug 2013 23:23:03 -0400 Subject: Refs #4041, fixing regressions & bugs in visualization refactor. --- plugins/DBStats/DBStats.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'plugins/DBStats/DBStats.php') diff --git a/plugins/DBStats/DBStats.php b/plugins/DBStats/DBStats.php index 593f2a9b64..630bf4fe57 100644 --- a/plugins/DBStats/DBStats.php +++ b/plugins/DBStats/DBStats.php @@ -105,7 +105,7 @@ class Piwik_DBStats extends Plugin $result['show_offset_information'] = false; $result['show_pagination_control'] = false; - $result['visualization_properties']['JqplotGraph']['show_all_ticks'] = true; + $result['visualization_properties']['jqplot_graph']['show_all_ticks'] = true; // translate the labels themselves $valueToTranslationStr = array( @@ -256,7 +256,7 @@ class Piwik_DBStats extends Plugin $properties['show_tag_cloud'] = false; $properties['show_table_all_columns'] = false; $properties['keep_summary_row'] = true; - $properties['visualization_properties']['HtmlTable']['disable_row_evolution'] = true; + $properties['visualization_properties']['table']['disable_row_evolution'] = true; $properties['translations'] = array( 'label' => Piwik_Translate('DBStats_Table'), 'year' => Piwik_Translate('CoreHome_PeriodYear'), -- cgit v1.2.3