From f16d27ec5b93d0ce4a082ac13590460df6bd8a52 Mon Sep 17 00:00:00 2001 From: Stefan Giehl Date: Mon, 17 Feb 2020 10:21:32 +0100 Subject: Fix some failing tests (#15564) * Ensure https warning is hidden in optout ui test * ensure to include image tests on travis * try to fix update test * improve feedback ui test * fix update ui test * try to fix 2factorauth ui test * updates expected test files * improve 2fa ui tests * improve usersmanager ui test * updates expected test file * try killing cookies on logout * allow some pixels difference for usermanager tests * try to fix randomly failing dashboard test * try to fix emptysite ui test * remove no longer needed ui file --- plugins/Feedback/tests/UI/FeedbackPopup_spec.js | 6 +++++- .../UI/expected-screenshots/FeedbackPopup_dashboard_no_popup.png | 3 --- 2 files changed, 5 insertions(+), 4 deletions(-) delete mode 100644 plugins/Feedback/tests/UI/expected-screenshots/FeedbackPopup_dashboard_no_popup.png (limited to 'plugins/Feedback') diff --git a/plugins/Feedback/tests/UI/FeedbackPopup_spec.js b/plugins/Feedback/tests/UI/FeedbackPopup_spec.js index d642984ed1..5073ff9594 100644 --- a/plugins/Feedback/tests/UI/FeedbackPopup_spec.js +++ b/plugins/Feedback/tests/UI/FeedbackPopup_spec.js @@ -37,6 +37,10 @@ describe("FeedbackPopup", function () { await page.goto(url); await page.waitForNetworkIdle(); - expect(await page.screenshotSelector('#root')).to.matchImage('dashboard_no_popup'); + // check dashboard is present + await page.waitForSelector('#dashboardWidgetsArea'); + + // check modal isn't opened + await page.waitForFunction("$('.modal.open').length == 0"); }); }); \ No newline at end of file diff --git a/plugins/Feedback/tests/UI/expected-screenshots/FeedbackPopup_dashboard_no_popup.png b/plugins/Feedback/tests/UI/expected-screenshots/FeedbackPopup_dashboard_no_popup.png deleted file mode 100644 index 58cfb5aacf..0000000000 --- a/plugins/Feedback/tests/UI/expected-screenshots/FeedbackPopup_dashboard_no_popup.png +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:44c97885caf1a5e6148023cfcd323ad51415e0eabac3e08f7e91f1da6a93b6a1 -size 409180 -- cgit v1.2.3