From e4c1f1f92114ca03947e9932935e4b4195ae1604 Mon Sep 17 00:00:00 2001
From: diosmosis <diosmosis@users.noreply.github.com>
Date: Mon, 15 Jul 2019 21:33:25 -0700
Subject: Keep top level nb_visits_converted metric (#14253)

* Do not remove nb_visits_converted when archiving goal reports since it should differ from sum of conversions.

* If metric is not available, compute dynamically by using max nb_visits_converted.

* Ignore abandoned cart conversions when calculating visit converted.

* In case goals column is empty.

* remove processed metric code since it is not correct

* do not remove visits converted metric for overview

* fix tests

* Fixing test

* fix test

* update test files

* update submodules

* Update expected screenshots & try to fix some random failures.

* Update expected UI test export results.

* two ui test fixes

* Fix couple UI test failures.

* fix random php test failure
---
 ...nversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml | 1 +
 1 file changed, 1 insertion(+)

(limited to 'plugins/Goals/tests/System/expected')

diff --git a/plugins/Goals/tests/System/expected/test_trackGoals_allowMultipleConversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml b/plugins/Goals/tests/System/expected/test_trackGoals_allowMultipleConversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml
index a5df90f990..4a3f7b7062 100644
--- a/plugins/Goals/tests/System/expected/test_trackGoals_allowMultipleConversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml
+++ b/plugins/Goals/tests/System/expected/test_trackGoals_allowMultipleConversionsPerVisit__VisitTime.getVisitInformationPerServerTime_day.xml
@@ -9,6 +9,7 @@
 		<max_actions>3</max_actions>
 		<sum_visit_length>363</sum_visit_length>
 		<bounce_count>0</bounce_count>
+		<nb_visits_converted>2</nb_visits_converted>
 		<goals>
 			<row idgoal='1'>
 				<nb_conversions>2</nb_conversions>
-- 
cgit v1.2.3