From 2cabc570e84b938920d797ae7999c1ddad28f962 Mon Sep 17 00:00:00 2001 From: diosmosis Date: Thu, 9 Jul 2015 16:11:01 -0700 Subject: Move last remaining ping request handling logic to PingRequestProcessor from Visit::handle(). --- plugins/Heartbeat/Tracker/PingRequestProcessor.php | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'plugins/Heartbeat') diff --git a/plugins/Heartbeat/Tracker/PingRequestProcessor.php b/plugins/Heartbeat/Tracker/PingRequestProcessor.php index d513e3f223..9e45e0c057 100644 --- a/plugins/Heartbeat/Tracker/PingRequestProcessor.php +++ b/plugins/Heartbeat/Tracker/PingRequestProcessor.php @@ -32,7 +32,17 @@ class PingRequestProcessor extends RequestProcessor if ($this->isPingRequest($request)) { $visitProperties->setRequestMetadata('Goals', 'someGoalsConverted', false); $visitProperties->setRequestMetadata('Goals', 'visitIsConverted', false); + // TODO: double check: can this be merged w/ setting action to null? + + // When a ping request is received more than 30 min after the last request/ping, + // we choose not to create a new visit. + if ($visitProperties->getRequestMetadata('CoreHome', 'isNewVisit')) { + Common::printDebug("-> ping=1 request: we do _not_ create a new visit."); + return true; // abort request + } } + + return false; } private function isPingRequest(Request $request) -- cgit v1.2.3