From 3821a56d0677d3602fb77aba52b6fbe55a6de0c1 Mon Sep 17 00:00:00 2001 From: diosmosis Date: Tue, 7 Jul 2015 22:24:15 -0700 Subject: Move more conversion/actions related logic from Visit::handle() to plugin specific RequestProcessors in manipulateVisitProperties method. Also temporarily made GoalManager a singleton that is set as a static var in GoalsRequestProcessor. Should be in DI, but until all of Visit::handle() is dealt w/, this can't be done. --- plugins/Heartbeat/Tracker/PingRequestProcessor.php | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'plugins/Heartbeat') diff --git a/plugins/Heartbeat/Tracker/PingRequestProcessor.php b/plugins/Heartbeat/Tracker/PingRequestProcessor.php index 44224ce0ab..d513e3f223 100644 --- a/plugins/Heartbeat/Tracker/PingRequestProcessor.php +++ b/plugins/Heartbeat/Tracker/PingRequestProcessor.php @@ -24,7 +24,12 @@ class PingRequestProcessor extends RequestProcessor Common::printDebug("-> ping=1 request: we do not track a new action nor a new visit nor any goal."); $visitProperties->setRequestMetadata('Actions', 'action', null); + } + } + public function manipulateVisitProperties(VisitProperties $visitProperties, Request $request) + { + if ($this->isPingRequest($request)) { $visitProperties->setRequestMetadata('Goals', 'someGoalsConverted', false); $visitProperties->setRequestMetadata('Goals', 'visitIsConverted', false); } -- cgit v1.2.3