From bc1d57f6dc43e843d26cbb5e484539201f518cf9 Mon Sep 17 00:00:00 2001
From: dizzy <diosmosis@users.noreply.github.com>
Date: Tue, 9 Feb 2021 21:37:26 -0800
Subject: Display help icons for categories/subcategories  (#17062)

* show help icons in left and display help messages on click

* pointless commit

* more fixes for when to show icon persistent

* More docs & more fixes.

* some fixes, more styling changes + UI test

* remove line breaks

* fix link

* update SecurityInfo plugin to latest

* apply more review feedback

* Adding help text + tweak to notification title bar.

* fix issues after review and make exception clearer

* update submodules

* Update CustomVariables submodule.

* fixing tests

* fix test

Co-authored-by: sgiehl <stefan@matomo.org>
---
 plugins/PagePerformance/Categories/PerformanceSubcategory.php | 6 ++++++
 plugins/PagePerformance/lang/en.json                          | 4 +++-
 2 files changed, 9 insertions(+), 1 deletion(-)

(limited to 'plugins/PagePerformance')

diff --git a/plugins/PagePerformance/Categories/PerformanceSubcategory.php b/plugins/PagePerformance/Categories/PerformanceSubcategory.php
index e8f21cd27e..9644ed68b0 100644
--- a/plugins/PagePerformance/Categories/PerformanceSubcategory.php
+++ b/plugins/PagePerformance/Categories/PerformanceSubcategory.php
@@ -9,6 +9,7 @@
 namespace Piwik\Plugins\PagePerformance\Categories;
 
 use Piwik\Category\Subcategory;
+use Piwik\Piwik;
 
 class PerformanceSubcategory extends Subcategory
 {
@@ -16,4 +17,9 @@ class PerformanceSubcategory extends Subcategory
     protected $id = 'PagePerformance_Performance';
     protected $order = 47;
 
+    public function getHelp()
+    {
+        return '<p>' . Piwik::translate('PagePerformance_PerformanceSubcategoryHelp1') . '</p>'
+            . '<p>' . Piwik::translate('PagePerformance_PerformanceSubcategoryHelp2') . '</p>';
+    }
 }
diff --git a/plugins/PagePerformance/lang/en.json b/plugins/PagePerformance/lang/en.json
index 0292ab6c94..d93b48e78a 100644
--- a/plugins/PagePerformance/lang/en.json
+++ b/plugins/PagePerformance/lang/en.json
@@ -36,6 +36,8 @@
         "HelpNote": "Some of those metrics might not always be available. You can find more information in our %1$sonline guide%2$s.",
         "RowActionTitle": "Open page performance report",
         "RowActionDescription": "Show page performance report for this row",
-        "PagePerformanceTitle": "Page performance for page with %1$s \"%2$s\""
+        "PagePerformanceTitle": "Page performance for page with %1$s \"%2$s\"",
+        "PerformanceSubcategoryHelp1": "The Performance section can help you analyse how fast your website or app is performing on the whole and help discover whether you have specific pages that significantly deviate from your averages.",
+        "PerformanceSubcategoryHelp2": "You can also find reports showing exactly how long each page of your website takes to load and what is contributing to their loading time."
     }
 }
-- 
cgit v1.2.3