From bd3e66993262f795a194386979cb56fe41ff6497 Mon Sep 17 00:00:00 2001 From: Ben Burgess <88810029+bx80@users.noreply.github.com> Date: Tue, 16 Nov 2021 11:49:33 +1300 Subject: Improvements to the in-app feature rating mechanism (#18280) * Changes to in-app feedback mechanism * Fix for dialog close issue * Update plugins/Feedback/API.php Co-authored-by: Stefan Giehl * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl * Added UI tests * UI improvements, shorter questions text, autofocus text field * Layout tweaks * Added custom questions for like choices * Fix for UI tests, added UI screenshot * Updated UI test screenshots * Updated UI test screenshots * Build vue * built vue files * Update plugins/Feedback/lang/en.json Co-authored-by: Stefan Giehl * Tidied message validation, text fixes, added privacy policy link * built vue files * Update plugins/Feedback/API.php * Update plugins/Feedback/API.php * built vue files * Added missing selection.json * Restored deleted ReviewLinks which is to be displayed after a positive Rate Feature * built vue files * Added null check for javascript focus call * built vue files * Remove unnecessary inline test check for rate feature feedback mail * Updated UI test screenshot Co-authored-by: Stefan Giehl Co-authored-by: bx80 Co-authored-by: sgiehl --- .../SegmentSelectorEditorTest_2_segment_editor_update.png | 4 ++-- .../SegmentSelectorEditorTest_3_segment_editor_edit_name.png | 4 ++-- .../SegmentSelectorEditorTest_8_segment_editor_create.png | 4 ++-- .../SegmentSelectorEditorTest_add_new_and_condition.png | 4 ++-- .../SegmentSelectorEditorTest_add_new_or_condition.png | 4 ++-- .../SegmentSelectorEditorTest_dimension_drag_drop.png | 4 ++-- .../SegmentSelectorEditorTest_drag_and_condition.png | 4 ++-- .../SegmentSelectorEditorTest_drag_or_condition.png | 4 ++-- .../SegmentSelectorEditorTest_enabled_create_realtime_segments.png | 4 ++-- .../expected-screenshots/SegmentSelectorEditorTest_saved_details.png | 4 ++-- .../SegmentSelectorEditorTest_suggested_values.png | 4 ++-- .../SegmentSelectorEditorTest_updated_details.png | 4 ++-- 12 files changed, 24 insertions(+), 24 deletions(-) (limited to 'plugins/SegmentEditor/tests') diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_2_segment_editor_update.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_2_segment_editor_update.png index 1387199ca0..02f6078410 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_2_segment_editor_update.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_2_segment_editor_update.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:a343494053418bdb2420a79ede4312d44c811507fce7186e2323b735c7152517 -size 35210 +oid sha256:f1af531786856e6064f1d5eee92cfcf6ff4bb55f8350425c9e6782b422609746 +size 35679 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_3_segment_editor_edit_name.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_3_segment_editor_edit_name.png index 6045c53a35..efa680e625 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_3_segment_editor_edit_name.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_3_segment_editor_edit_name.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:8ced9db25b6ede23ee8dc592b0d7339727a5a39378e1e77db190c1fd8641f008 -size 35736 +oid sha256:925e595dae3a1788bf5c186f3f095cc3a30a86e17b0d135c3a51584013fbdb2e +size 36194 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_8_segment_editor_create.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_8_segment_editor_create.png index f0e121c5a8..d09882fd5b 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_8_segment_editor_create.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_8_segment_editor_create.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:947ace71f336490f42b5a02b0c75b3e2640dd04ce6d32e3804bc9624c09c626d -size 31637 +oid sha256:ec2fad0f9a7066854d9d7f6ee2e9355040be0383ec5e8e6be36803c0e077f832 +size 32105 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_add_new_and_condition.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_add_new_and_condition.png index 31d898093c..b21b22ed55 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_add_new_and_condition.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_add_new_and_condition.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:711be5b80eec70d3a4feab174c7d3d7cdb0e229bd73c2fa4e6154fe76cee91ec -size 46109 +oid sha256:10a54070979f44fbd99d8b187d1a1b05f56cb7af64a7d8db0bdf0601b44bc7f1 +size 46579 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_add_new_or_condition.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_add_new_or_condition.png index f6c1394717..aa6c1c075e 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_add_new_or_condition.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_add_new_or_condition.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:d2820216977a737bc67d1d44faf103f9d63b640d991a62e562988ec2d9fd58e2 -size 36194 +oid sha256:94a882f9f53d2c3b42c68a7a83eda6c3be1e3db752786cca402157b5577c7dc9 +size 36648 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_dimension_drag_drop.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_dimension_drag_drop.png index eac36cdc07..0ddfb54d2c 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_dimension_drag_drop.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_dimension_drag_drop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:76752106a18b1be7ea6d5a96ee1c5506af9f255b94441c5b24bb094349e683de -size 31049 +oid sha256:513ff434840a18cd7d82f522b8248eb24f901289db1426b445d971d2afbe7e06 +size 31521 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_drag_and_condition.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_drag_and_condition.png index 330f3e7437..e8568f2aa5 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_drag_and_condition.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_drag_and_condition.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:c9f1a841123a3281357ae4f481df580bcbc368cc9f8281ffe6c7aed7746a3743 -size 45783 +oid sha256:0d3ede82d7d001ee700275ed89b065f6306a31a61228105e2da6e07f64bdd49c +size 46251 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_drag_or_condition.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_drag_or_condition.png index 0ad8146a11..b3f4b3877e 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_drag_or_condition.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_drag_or_condition.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:70d9647ebbdb0157c645c15d655b53fa5a0b447de76adf8144c6002d7cd33d66 -size 35828 +oid sha256:4204d09e0ac02d269be1bb5bba981593cadb18dc68b3f96306c80140ec7c887e +size 36277 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_enabled_create_realtime_segments.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_enabled_create_realtime_segments.png index a0a23c54a1..647bb78d44 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_enabled_create_realtime_segments.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_enabled_create_realtime_segments.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:3b294dab4b6bc3518291c385c834b61151cdc62affd1eb5a356db2d18a60ed90 -size 28894 +oid sha256:fa9d1073467701e4755ba3496592b2fdb6ab0d49e21b23aa22878e8c1c12a568 +size 29349 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_saved_details.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_saved_details.png index e8a3180048..ef30bc3f15 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_saved_details.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_saved_details.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:eff8a925c8f9c1b072c294125eede776df828a7c33ee10307c68282249f3f330 -size 48182 +oid sha256:a169e356afc2a3921ec670773062b224386d9df64fd3ec49702433d9a8080646 +size 48665 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png index eaa19a1b7a..fb135e75b0 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_suggested_values.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e45b89ce929777b85711946e420be9abf9fd0d56ba20c64fbfc81e9f75d75582 -size 57402 +oid sha256:f123753378ce7a80459a436eff08e5bf9345b86d1246733451c8e2e314bb6f42 +size 57881 diff --git a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_updated_details.png b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_updated_details.png index 313b2d6383..b216380560 100644 --- a/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_updated_details.png +++ b/plugins/SegmentEditor/tests/UI/expected-screenshots/SegmentSelectorEditorTest_updated_details.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:37addc9332cacff2437a75dbee040de53ddaf4cd1d304f1055672f25e96904aa -size 48952 +oid sha256:842a1946a1f3557abe9d51d617289846fd851652fecbe300aa794ff1e78fcdaa +size 49513 -- cgit v1.2.3