From bc1d57f6dc43e843d26cbb5e484539201f518cf9 Mon Sep 17 00:00:00 2001 From: dizzy Date: Tue, 9 Feb 2021 21:37:26 -0800 Subject: Display help icons for categories/subcategories (#17062) * show help icons in left and display help messages on click * pointless commit * more fixes for when to show icon persistent * More docs & more fixes. * some fixes, more styling changes + UI test * remove line breaks * fix link * update SecurityInfo plugin to latest * apply more review feedback * Adding help text + tweak to notification title bar. * fix issues after review and make exception clearer * update submodules * Update CustomVariables submodule. * fixing tests * fix test Co-authored-by: sgiehl --- plugins/VisitTime/Categories/TimesSubcategory.php | 5 +++++ plugins/VisitTime/lang/en.json | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) (limited to 'plugins/VisitTime') diff --git a/plugins/VisitTime/Categories/TimesSubcategory.php b/plugins/VisitTime/Categories/TimesSubcategory.php index 701a5d6ec3..af28e252ba 100644 --- a/plugins/VisitTime/Categories/TimesSubcategory.php +++ b/plugins/VisitTime/Categories/TimesSubcategory.php @@ -9,6 +9,7 @@ namespace Piwik\Plugins\VisitTime\Categories; use Piwik\Category\Subcategory; +use Piwik\Piwik; class TimesSubcategory extends Subcategory { @@ -16,4 +17,8 @@ class TimesSubcategory extends Subcategory protected $id = 'VisitTime_SubmenuTimes'; protected $order = 35; + public function getHelp() + { + return '

' . Piwik::translate('VisitTime_TimesSubcategoryHelp') . '

'; + } } diff --git a/plugins/VisitTime/lang/en.json b/plugins/VisitTime/lang/en.json index 6ab07b2c31..d3674802b9 100644 --- a/plugins/VisitTime/lang/en.json +++ b/plugins/VisitTime/lang/en.json @@ -30,6 +30,7 @@ "WidgetLocalTime": "Visits by Local Time", "WidgetLocalTimeDocumentation": "This graph shows what time it was in the %1$s visitors' time zones %2$s during their visits.", "WidgetServerTime": "Visits by Server Time", - "WidgetServerTimeDocumentation": "This graph shows what time it was in the %1$s server's time zone %2$s during the visits." + "WidgetServerTimeDocumentation": "This graph shows what time it was in the %1$s server's time zone %2$s during the visits.", + "TimesSubcategoryHelp": "The Times section shows you when people are visiting your site. You can see the most popular local times your users visit at, so you can understand where your site fits into their life. Additionally, it shows the most popular server times, which can reveal demands on your technology stack." } } \ No newline at end of file -- cgit v1.2.3