From 40a8d65d6dd8f4f5fc601b78becf981f38e69eb4 Mon Sep 17 00:00:00 2001 From: Matthieu Aubry Date: Fri, 1 Dec 2017 15:42:34 +1300 Subject: New "Event URL" segment `eventUrl` to segment on any Segment URL (#12236) * New "Event URL" segment `eventUrl` to segment on any Segment URL Useful for many use cases for example: * Creating Custom Reports such as "Top page URLs by Event action" * Segmenting by Event URL and view events triggered on a specific Page URL * Fixes #11131 Action URL segment could filter both Page URLs OR Event URLs (as advertised originally in the 2.16.0 changelog but it wasn't actually fully working yet) * fix typo no capital letter * remove column type to prevent new column being created in the log_link_visit_action table * set correct action type for segment eventUrl * modify test * eventUrl needs action data * fix suggested values for eventUrl * update test files * event url is stored without protocol * update test file --- ...t_actionUrl__API.getSuggestedValuesForSegment.xml | 20 ++++++++++---------- ...estAPITest_actionUrl__VisitsSummary.get_range.xml | 18 +++++++++--------- ...st_eventUrl__API.getSuggestedValuesForSegment.xml | 4 ++++ ...gestAPITest_eventUrl__VisitsSummary.get_range.xml | 12 ++++++++++++ ...apiGetReportMetadata__API.getSegmentsMetadata.xml | 8 ++++++++ 5 files changed, 43 insertions(+), 19 deletions(-) create mode 100644 tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__API.getSuggestedValuesForSegment.xml create mode 100644 tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__VisitsSummary.get_range.xml (limited to 'tests/PHPUnit/System') diff --git a/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actionUrl__API.getSuggestedValuesForSegment.xml b/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actionUrl__API.getSuggestedValuesForSegment.xml index 2e03969e6d..2aaf85d5c1 100644 --- a/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actionUrl__API.getSuggestedValuesForSegment.xml +++ b/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actionUrl__API.getSuggestedValuesForSegment.xml @@ -1,23 +1,23 @@ - http://piwik.net/grue/lair http://piwik.net/space/quest/iv - http://example-outlink.org/1.html + http://piwik.net/grue/lair http://example.org/path/file1.zip http://example.org/path/file0.zip + http://example-outlink.org/1.html http://example-outlink.org/0.html - http://example.org/path/file2.zip - http://example.org/path/file3.zip http://example-outlink.org/3.html + http://example.org/path/file3.zip http://example-outlink.org/2.html + http://example.org/path/file2.zip + http://example-outlink.org/7.html + http://example-outlink.org/8.html http://example.org/path/file4.zip - http://example.org/path/file5.zip - http://example.org/path/file8.zip http://example-outlink.org/6.html - http://example-outlink.org/7.html - http://example-outlink.org/5.html + http://example.org/path/file6.zip http://example-outlink.org/4.html + http://example-outlink.org/5.html + http://example.org/path/file8.zip http://example.org/path/file7.zip - http://example-outlink.org/8.html - http://example.org/path/file6.zip + http://example.org/path/file5.zip \ No newline at end of file diff --git a/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actionUrl__VisitsSummary.get_range.xml b/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actionUrl__VisitsSummary.get_range.xml index 7ace3fcbe7..eb20b7dcf9 100644 --- a/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actionUrl__VisitsSummary.get_range.xml +++ b/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_actionUrl__VisitsSummary.get_range.xml @@ -1,12 +1,12 @@ - 18 - 18 - 18 - 18 - 0 - 1 - 100% - 1 - 0 + 17 + 77 + 17 + 0 + 27557 + 5 + 0% + 4.5 + 1621 \ No newline at end of file diff --git a/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__API.getSuggestedValuesForSegment.xml b/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__API.getSuggestedValuesForSegment.xml new file mode 100644 index 0000000000..60d14d644c --- /dev/null +++ b/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__API.getSuggestedValuesForSegment.xml @@ -0,0 +1,4 @@ + + + http://piwik.net/space/quest/iv + \ No newline at end of file diff --git a/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__VisitsSummary.get_range.xml b/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__VisitsSummary.get_range.xml new file mode 100644 index 0000000000..eb20b7dcf9 --- /dev/null +++ b/tests/PHPUnit/System/expected/test_AutoSuggestAPITest_eventUrl__VisitsSummary.get_range.xml @@ -0,0 +1,12 @@ + + + 17 + 77 + 17 + 0 + 27557 + 5 + 0% + 4.5 + 1621 + \ No newline at end of file diff --git a/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml b/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml index d72a0e6802..fee1d0ac41 100644 --- a/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml +++ b/tests/PHPUnit/System/expected/test_apiGetReportMetadata__API.getSegmentsMetadata.xml @@ -460,6 +460,7 @@ pageUrl downloadUrl outlinkUrl + eventUrl @@ -576,6 +577,13 @@ Event Name eventName + + dimension + Events + Event URL + eventUrl + The URL must be URL encoded, for example: http%3A%2F%2Fexample.com%2Fpath%2Fpage%3Fquery + dimension Referrers -- cgit v1.2.3