Welcome to mirror list, hosted at ThFree Co, Russian Federation.

BruteForceDetectionTest.php « Security « Integration « tests « Login « plugins - github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
blob: 45c6d9877dea3f08c1a481c9dce38a02b4f9076f (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
<?php
/**
 * Matomo - free/libre analytics platform
 *
 * @link https://matomo.org
 * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
 */

namespace Piwik\Plugins\Login\tests\Integration\Security;

use Piwik\Date;
use Piwik\Mail;
use Piwik\Piwik;
use Piwik\Plugins\Login\Emails\SuspiciousLoginAttemptsInLastHourEmail;
use Piwik\Plugins\Login\Security\BruteForceDetection;
use Piwik\Plugins\Login\SystemSettings;
use Piwik\Plugins\UsersManager\API;
use Piwik\Tests\Framework\TestCase\IntegrationTestCase;

class CustomBruteForceDetection extends BruteForceDetection {
    /**
     * @var Date
     */
    private $now;

    public function setNow($now)
    {
        $this->now = $now;
    }

    public function getNow()
    {
        if (!isset($this->now)) {
            return Date::factory('2018-09-23 12:40:10');
        }

        return $this->now;
    }

    protected function getOverallLoginLockoutThreshold()
    {
        return 3;
    }
}

/**
 * @group Login
 * @group BruteForceDetection
 */
class BruteForceDetectionTest extends IntegrationTestCase
{
    /**
     * @var CustomBruteForceDetection
     */
    private $detection;

    /**
     * @var SystemSettings
     */
    private $settings;

    public function setUp(): void
    {
        parent::setUp();

        $this->settings = new SystemSettings();
        $this->settings->loginAttemptsTimeRange->setValue(10);
        $this->settings->maxFailedLoginsPerMinutes->setValue(5);
        $this->settings->whitelisteBruteForceIps->setValue(array('10.99.99.99'));
        $this->settings->blacklistedBruteForceIps->setValue(array('10.55.55.55'));
        $this->detection = new CustomBruteForceDetection($this->settings, new \Piwik\Plugins\Login\Model());
    }

    public function test_isEnabled_isEnabledByDefault()
    {
        $this->assertTrue($this->detection->isEnabled());
    }

    public function test_addFailedAttempt_addsEntries()
    {
        $this->addFailedLoginInPast('127.0.0.1', 1);
        $this->addFailedLoginInPast('2001:0db8:85a3:0000:0000:8a2e:0370:7334', 2);
        $this->addFailedLoginInPast('10.1.2.3', 3);
        $this->addFailedLoginInPast('2001:0db8:85a3:0000:0000:8a2e:0370:7334', 4);
        $this->addFailedLoginInPast('10.1.2.3', 5);

        $entries = $this->detection->getAll();
        $expected = array (
                array (
                    'id_brute_force_log' => '1',
                    'ip_address' => '127.0.0.1',
                    'attempted_at' => '2018-09-23 12:39:10',
                    'login' => null,
                ),
                array (
                    'id_brute_force_log' => '2',
                    'ip_address' => '2001:0db8:85a3:0000:0000:8a2e:0370:7334',
                    'attempted_at' => '2018-09-23 12:38:10',
                    'login' => null,
                ),
                array (
                    'id_brute_force_log' => '3',
                    'ip_address' => '10.1.2.3',
                    'attempted_at' => '2018-09-23 12:37:10',
                    'login' => null,
                ),
                array (
                    'id_brute_force_log' => '4',
                    'ip_address' => '2001:0db8:85a3:0000:0000:8a2e:0370:7334',
                    'attempted_at' => '2018-09-23 12:36:10',
                    'login' => null,
                ),
                array (
                    'id_brute_force_log' => '5',
                    'ip_address' => '10.1.2.3',
                    'attempted_at' => '2018-09-23 12:35:10',
                    'login' => null,
                ),
        );
        $this->assertEquals($expected, $entries);
    }

    public function test_unblockIp_onlyRemovesRecentEntriesOfIp()
    {
        $now = $this->detection->getNow();
        $this->addFailedLoginInPast('127.0.0.1',1);
        $this->addFailedLoginInPast('10.1.2.3', 2); // should be deleted
        $this->addFailedLoginInPast('10.1.2.3', 3); // should be deleted

        // those should not be touched
        $this->detection->setNow($now->subDay(20));
        $this->detection->addFailedAttempt('2001:0db8:85a3:0000:0000:8a2e:0370:7334');
        $this->detection->addFailedAttempt('10.1.2.3');

        $this->detection->setNow($now);
        $this->assertCount(5, $this->detection->getAll());

        $this->detection->unblockIp('10.1.2.3');

        $entries = $this->detection->getAll();
        $expected = array (
                array (
                    'id_brute_force_log' => '1',
                    'ip_address' => '127.0.0.1',
                    'attempted_at' => '2018-09-23 12:39:10',
                    'login' => null,
                ),
                array (
                    'id_brute_force_log' => '4',
                    'ip_address' => '2001:0db8:85a3:0000:0000:8a2e:0370:7334',
                    'attempted_at' => '2018-09-03 12:40:10',
                    'login' => null,
                ),
                array (
                    'id_brute_force_log' => '5',
                    'ip_address' => '10.1.2.3',
                    'attempted_at' => '2018-09-03 12:40:10',
                    'login' => null,
                ),
        );
        $this->assertEquals($expected, $entries);
    }

    public function test_cleanupOldEntries_onlyRemovesOldEntries()
    {
        $now = $this->detection->getNow();
        // these should be kept cause they are recent
        $this->addFailedLoginInPast('127.0.0.1', 1);
        $this->addFailedLoginInPast('10.1.2.3', 2, 'auser');

        $this->detection->setNow($now->subDay(5));
        $this->detection->addFailedAttempt('10.1.2.6');

        // those should be cleaned up
        $this->detection->setNow($now->subDay(10));
        $this->detection->addFailedAttempt('2001:0db8:85a3:0000:0000:8a2e:0370:7334');
        $this->detection->addFailedAttempt('10.1.2.4');

        $this->detection->setNow($now);
        $this->assertCount(5, $this->detection->getAll());

        $this->detection->cleanupOldEntries();

        $entries = $this->detection->getAll();
        $expected = array (
                array (
                    'id_brute_force_log' => '1',
                    'ip_address' => '127.0.0.1',
                    'attempted_at' => '2018-09-23 12:39:10',
                    'login' => null,
                ),
                array (
                    'id_brute_force_log' => '2',
                    'ip_address' => '10.1.2.3',
                    'attempted_at' => '2018-09-23 12:38:10',
                    'login' => 'auser',
                ),
                array (
                    'id_brute_force_log' => '3',
                    'ip_address' => '10.1.2.6',
                    'attempted_at' => '2018-09-18 12:40:10',
                    'login' => null,
                ),
        );
        $this->assertEquals($expected, $entries);
    }

    public function test_getCurrentlyBlockedIps_noIpBlockedWhenNonAdded()
    {
        $this->assertEquals(array(), $this->detection->getCurrentlyBlockedIps());
    }

    public function test_getCurrentlyBlockedIps_noIpBlockedWhenOnlyRecentOnesAdded()
    {
        $this->detection->addFailedAttempt('127.0.0.1');
        $this->detection->addFailedAttempt('2001:0db8:85a3:0000:0000:8a2e:0370:7334');
        $this->detection->addFailedAttempt('10.1.2.3');
        $this->detection->addFailedAttempt('2001:0db8:85a3:0000:0000:8a2e:0370:7334');
        $this->detection->addFailedAttempt('10.1.2.3');

        $this->assertEquals(array(), $this->detection->getCurrentlyBlockedIps());
    }

    public function test_getCurrentlyBlockedIps_isAllowedToLogin_onlyBlockedWhenMaxAttemptsReached()
    {
        $this->addFailedLoginInPast('127.0.0.1', 1);
        $this->addFailedLoginInPast('2001:0db8:85a3:0000:0000:8a2e:0370:7334', 2);
        $this->addFailedLoginInPast('10.1.2.3', 3);
        $this->addFailedLoginInPast('10.1.2.3', 5);
        $this->addFailedLoginInPast('10.1.2.3', 7);
        $this->addFailedLoginInPast('10.1.2.3', 9); // 4 logins per 10 minute allowed

        // now we make sure more than 10 minutes ago there were heaps of entries and the user was actually blocked...
        // but not anymore cause only last 10 min matters
        $this->addFailedLoginInPast('10.1.2.3', 11);
        $this->addFailedLoginInPast('10.1.2.3', 12);
        for ($i = 0; $i < 20; $i++) {
            $this->addFailedLoginInPast('10.1.2.3', 14);
        }

        $this->assertEquals(array(), $this->detection->getCurrentlyBlockedIps());
        $this->assertTrue($this->detection->isAllowedToLogin('10.1.2.3'));
        $this->assertTrue($this->detection->isAllowedToLogin('127.0.0.1'));

        $this->detection->setNow($this->detection->getNow()->subPeriod(10, 'minute'));

        // now we go 10 min back and the user will be blocked
        $this->assertEquals(array('10.1.2.3'), $this->detection->getCurrentlyBlockedIps());
        $this->assertFalse($this->detection->isAllowedToLogin('10.1.2.3'));
        $this->assertTrue($this->detection->isAllowedToLogin('127.0.0.1'));
    }

    public function test_getCurrentlyBlockedIps_isAllowedToLogin_whitelistedIpCanAlwaysLoginAndIsNeverBlocked()
    {
        for ($i = 0; $i < 20; $i++) {
            $this->addFailedLoginInPast('10.99.99.99', 1);
            $this->addFailedLoginInPast('127.0.0.1', 1);
        }

        $this->assertEquals(array('127.0.0.1'), $this->detection->getCurrentlyBlockedIps());
        $this->assertTrue($this->detection->isAllowedToLogin('10.99.99.99'));
        $this->assertFalse($this->detection->isAllowedToLogin('127.0.0.1'));
    }

    public function test_getCurrentlyBlockedIps_isAllowedToLogin_blacklistedIpCanNeverLogIn_EvenWhenNoFailedAttempts()
    {
        $this->assertEquals(array(), $this->detection->getCurrentlyBlockedIps());
        $this->assertEquals(array(), $this->detection->getAll());
        $this->assertFalse($this->detection->isAllowedToLogin('10.55.55.55'));
    }

    public function test_isUserLoginBlocked_returnsTrueIfThereAreMoreThanTheThresholdNumOfAttempts()
    {
        $this->detection->setNow(Date::now());

        $sentMail = null;
        Piwik::addAction('Mail.send', function (Mail $mail) use (&$sentMail) {
            $sentMail = $mail;
        });

        $this->addFailedAttemptsWithLogin();

        $this->assertTrue($this->detection->isUserLoginBlocked('theuser'));
        $this->assertNull($sentMail); // user does not exist so no mail sent
    }

    public function test_isUserLoginBlocked_sendsEmailIfLoginIsForRealUser()
    {
        $this->detection->setNow(Date::now());

        API::getInstance()->addUser('theuser', 'averybadpwd', 'someemail@email.com');

        /** @var SuspiciousLoginAttemptsInLastHourEmail $sentMail */
        $sentMail = null;
        Piwik::addAction('Mail.send', function (Mail $mail) use (&$sentMail) {
            $sentMail = $mail;
        });

        $this->addFailedAttemptsWithLogin();

        $this->assertTrue($this->detection->isUserLoginBlocked('theuser'));
        $this->assertNotNull($sentMail);
        $this->assertInstanceOf(SuspiciousLoginAttemptsInLastHourEmail::class, $sentMail);
        $this->assertEquals(['someemail@email.com' => ''], $sentMail->getRecipients());
    }

    public function test_isUserLoginBlocked_returnsFalseIfThereAreLessThanTheThresholdNumOfAttempts()
    {
        $this->detection->setNow(Date::now());

        $this->addFailedAttemptsWithLogin();

        $this->assertFalse($this->detection->isUserLoginBlocked('anotheruser'));
    }

    private function addFailedLoginInPast($ipAddress, $minutes, $login = null)
    {
        $now = $this->detection->getNow();
        $this->detection->setNow($now->subPeriod($minutes, 'minute'));
        $this->detection->addFailedAttempt($ipAddress, $login);
        $this->detection->setNow($now);
    }

    private function addFailedAttemptsWithLogin()
    {
        for ($i = 0; $i < 5; $i++) {
            $this->addFailedLoginInPast('10.99.99.' . $i, $i * 5, 'theuser');
        }

        for ($i = 0; $i < 2; $i++) {
            $this->addFailedLoginInPast('10.99.99.' . $i, $i * 5, 'anotheruser');
        }

        $this->addFailedLoginInPast('10.99.88.1', 75, 'theuser');
    }

}