1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
|
<?php
/**
* Matomo - free/libre analytics platform
*
* @link https://matomo.org
* @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/
namespace Piwik\Plugins\TwoFactorAuth\tests\Integration;
use Piwik\API\Request;
use Piwik\Container\StaticContainer;
use Piwik\Plugins\TwoFactorAuth\Dao\RecoveryCodeDao;
use Piwik\Plugins\TwoFactorAuth\Dao\TwoFaSecretRandomGenerator;
use Piwik\Plugins\TwoFactorAuth\SystemSettings;
use Piwik\Plugins\TwoFactorAuth\TwoFactorAuthentication;
use Piwik\Plugins\UsersManager\API;
use Piwik\Plugins\UsersManager\UserUpdater;
use Piwik\Tests\Framework\TestCase\IntegrationTestCase;
/**
* @group TwoFactorAuth
* @group Plugins
*/
class TwoFactorAuthTest extends IntegrationTestCase
{
/**
* @var RecoveryCodeDao
*/
private $dao;
/**
* @var SystemSettings
*/
private $settings;
/**
* @var TwoFactorAuthentication
*/
private $twoFa;
private $userWith2Fa = 'myloginWith';
private $userWithout2Fa = 'myloginWithout';
private $userPassword = '123abcDk3_l3';
private $user2faSecret = '123456';
public function setUp(): void
{
parent::setUp();
foreach ([$this->userWith2Fa, $this->userWithout2Fa] as $user) {
API::getInstance()->addUser($user, $this->userPassword, $user . '@matomo.org');
$userUpdater = new UserUpdater();
$userUpdater->setSuperUserAccessWithoutCurrentPassword($user, 1);
}
$this->dao = StaticContainer::get(RecoveryCodeDao::class);
$this->settings = new SystemSettings();
$secretGenerator = new TwoFaSecretRandomGenerator();
$this->twoFa = new TwoFactorAuthentication($this->settings, $this->dao, $secretGenerator);
$this->dao->createRecoveryCodesForLogin($this->userWith2Fa);
$this->twoFa->saveSecret($this->userWith2Fa, $this->user2faSecret);
unset($_GET['authCode']);
}
public function tearDown(): void
{
unset($_GET['authCode']);
}
public function test_onCreateAppSpecificTokenAuth_canAuthenticateWhenUserNotUsesTwoFA()
{
$token = Request::processRequest('UsersManager.createAppSpecificTokenAuth', array(
'userLogin' => $this->userWithout2Fa,
'passwordConfirmation' => $this->userPassword,
'description' => 'twofa test'
));
$this->assertEquals(32, strlen($token));
}
public function test_onCreateAppSpecificTokenAuth_failsWhenNotAuthenticatedEvenWhen2FAenabled()
{
$this->expectException(\Exception::class);
$this->expectExceptionMessage('UsersManager_CurrentPasswordNotCorrect');
Request::processRequest('UsersManager.createAppSpecificTokenAuth', array(
'userLogin' => $this->userWith2Fa,
'passwordConfirmation' => 'invalidPAssword',
'description' => 'twofa test'
));
}
public function test_onCreateAppSpecificTokenAuth_throwsErrorWhenMissingTokenWhenUsing2FaAndAuthenticatedCorrectly()
{
$this->expectException(\Exception::class);
$this->expectExceptionMessage('TwoFactorAuth_MissingAuthCodeAPI');
Request::processRequest('UsersManager.createAppSpecificTokenAuth', array(
'userLogin' => $this->userWith2Fa,
'passwordConfirmation' => $this->userPassword,
'description' => 'twofa test'
));
}
public function test_onCreateAppSpecificTokenAuth_throwsErrorWhenInvalidTokenWhenUsing2FaAndAuthenticatedCorrectly()
{
$this->expectException(\Exception::class);
$this->expectExceptionMessage('TwoFactorAuth_InvalidAuthCode');
$_GET['authCode'] = '111222';
Request::processRequest('UsersManager.createAppSpecificTokenAuth', array(
'userLogin' => $this->userWith2Fa,
'passwordConfirmation' => $this->userPassword,
'description' => 'twofa test'
));
}
public function test_onCreateAppSpecificTokenAuth_returnsCorrectTokenWhenProvidingCorrectAuthTokenOnAuthentication()
{
$_GET['authCode'] = $this->generateValidAuthCode($this->user2faSecret);
$token = Request::processRequest('UsersManager.createAppSpecificTokenAuth', array(
'userLogin' => $this->userWith2Fa,
'passwordConfirmation' => $this->userPassword,
'description' => 'twofa test'
));
$this->assertEquals(32, strlen($token));
}
public function test_onDeleteUser_RemovesAllRecoveryCodesWhenUsingTwoFa()
{
$this->assertNotEmpty($this->dao->getAllRecoveryCodesForLogin($this->userWith2Fa));
Request::processRequest('UsersManager.deleteUser', array(
'userLogin' => $this->userWith2Fa
));
$this->assertEmpty($this->dao->getAllRecoveryCodesForLogin($this->userWith2Fa));
}
public function test_onDeleteUser_DoesNotFailToDeleteUserNotUsingTwoFa()
{
$this->expectNotToPerformAssertions();
Request::processRequest('UsersManager.deleteUser', array(
'userLogin' => $this->userWithout2Fa
));
}
private function generateValidAuthCode($secret)
{
$code = new \TwoFactorAuthenticator();
return $code->getCode($secret);
}
}
|
