diff options
| author | João Moreno <mail@joaomoreno.com> | 2018-12-11 17:17:17 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-11 17:17:17 +0300 |
| commit | c6e592b2b5770e40a98cb9c2715a8ef89aec3d74 (patch) | |
| tree | 3129d23c84914308ed2851a018ec069f4a45fbd7 | |
| parent | 3dcdcc3fe0ed44d8c58be03df3c35e1edcb454e9 (diff) | |
| parent | 552023ed54b41565fc3c513266a4a776cce0b00f (diff) | |
Merge pull request #64803 from Microsoft/joao/release/1.30/fix-647391.30.0
Fixes #64739
| -rw-r--r-- | src/vs/platform/update/electron-main/updateService.darwin.ts | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/vs/platform/update/electron-main/updateService.darwin.ts b/src/vs/platform/update/electron-main/updateService.darwin.ts index 768cbcad49f..7c9f6d93a48 100644 --- a/src/vs/platform/update/electron-main/updateService.darwin.ts +++ b/src/vs/platform/update/electron-main/updateService.darwin.ts @@ -46,7 +46,8 @@ export class DarwinUpdateService extends AbstractUpdateService { this.logService.error('UpdateService error:', err); // only show message when explicitly checking for updates - const message: string | undefined = !!context ? err : undefined; + const shouldShowMessage = this.state.type === StateType.CheckingForUpdates ? !!this.state.context : true; + const message: string | undefined = shouldShowMessage ? err : undefined; this.setState(State.Idle(UpdateType.Archive, message)); } |