diff options
| author | Martin Aeschlimann <martinae@microsoft.com> | 2020-05-29 14:45:54 +0300 |
|---|---|---|
| committer | Martin Aeschlimann <martinae@microsoft.com> | 2020-05-29 14:58:33 +0300 |
| commit | c1575cfb9ac273724bf12f9ba475db155d56c7a9 (patch) | |
| tree | 3b0a00b22921add7362479ea351473d0fa1ac4e7 | |
| parent | 2b177467e0de7c7c0aa2b33e34f8f8de0bd965f0 (diff) | |
don't warn with browser-only extensions
| -rw-r--r-- | src/vs/platform/extensions/common/extensions.ts | 1 | ||||
| -rw-r--r-- | src/vs/workbench/services/extensions/node/extensionPoints.ts | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/vs/platform/extensions/common/extensions.ts b/src/vs/platform/extensions/common/extensions.ts index ac6ec196a03..3c9bede84fe 100644 --- a/src/vs/platform/extensions/common/extensions.ts +++ b/src/vs/platform/extensions/common/extensions.ts @@ -149,6 +149,7 @@ export interface IExtensionManifest { readonly engines: { vscode: string }; readonly description?: string; readonly main?: string; + readonly browser?: string; readonly icon?: string; readonly categories?: string[]; readonly keywords?: string[]; diff --git a/src/vs/workbench/services/extensions/node/extensionPoints.ts b/src/vs/workbench/services/extensions/node/extensionPoints.ts index 9961f497f49..ab1480d249b 100644 --- a/src/vs/workbench/services/extensions/node/extensionPoints.ts +++ b/src/vs/workbench/services/extensions/node/extensionPoints.ts @@ -379,7 +379,7 @@ class ExtensionManifestValidator extends ExtensionManifestHandler { notices.push(nls.localize('extensionDescription.activationEvents1', "property `{0}` can be omitted or must be of type `string[]`", 'activationEvents')); return false; } - if (typeof extensionDescription.main === 'undefined') { + if (typeof extensionDescription.main === 'undefined' && typeof extensionDescription.browser === 'undefined') { notices.push(nls.localize('extensionDescription.activationEvents2', "properties `{0}` and `{1}` must both be specified or must both be omitted", 'activationEvents', 'main')); return false; } |