diff options
| author | Tyler James Leonhardt <me@tylerleonhardt.com> | 2022-06-30 12:11:48 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-30 12:11:48 +0300 |
| commit | 13f136fc46863edec7cd523eab43ae9ab5838aa0 (patch) | |
| tree | c08cfbf3e2e4302ae957db8b9ad52d06d2dc0947 /build | |
| parent | 944c6ca1045f6fad00073e96ef2da42fe30d48dd (diff) | |
Include comments exporting of translations (#153769)
Include comments in call to addFile. Fixes #150990
Diffstat (limited to 'build')
| -rw-r--r-- | build/lib/i18n.js | 17 | ||||
| -rw-r--r-- | build/lib/i18n.ts | 17 |
2 files changed, 24 insertions, 10 deletions
diff --git a/build/lib/i18n.js b/build/lib/i18n.js index dc7c12459b7..13de16ce9a0 100644 --- a/build/lib/i18n.js +++ b/build/lib/i18n.js @@ -599,17 +599,24 @@ function createXlfFilesForExtensions() { const basename = path.basename(file.path); if (basename === 'package.nls.json') { const json = JSON.parse(buffer.toString('utf8')); - const keys = Object.keys(json); - const messages = keys.map((key) => { + const keys = []; + const messages = []; + Object.keys(json).forEach((key) => { const value = json[key]; if (Is.string(value)) { - return value; + keys.push(key); + messages.push(value); } else if (value) { - return value.message; + keys.push({ + key, + comment: value.comment + }); + messages.push(value.message); } else { - return `Unknown message for key: ${key}`; + keys.push(key); + messages.push(`Unknown message for key: ${key}`); } }); getXlf().addFile(`extensions/${extensionName}/package`, keys, messages); diff --git a/build/lib/i18n.ts b/build/lib/i18n.ts index dae24b53679..05b0634120b 100644 --- a/build/lib/i18n.ts +++ b/build/lib/i18n.ts @@ -714,15 +714,22 @@ export function createXlfFilesForExtensions(): ThroughStream { const basename = path.basename(file.path); if (basename === 'package.nls.json') { const json: PackageJsonFormat = JSON.parse(buffer.toString('utf8')); - const keys = Object.keys(json); - const messages = keys.map((key) => { + const keys: Array<string | LocalizeInfo> = []; + const messages: string[] = []; + Object.keys(json).forEach((key) => { const value = json[key]; if (Is.string(value)) { - return value; + keys.push(key); + messages.push(value); } else if (value) { - return value.message; + keys.push({ + key, + comment: value.comment + }); + messages.push(value.message); } else { - return `Unknown message for key: ${key}`; + keys.push(key); + messages.push(`Unknown message for key: ${key}`); } }); getXlf().addFile(`extensions/${extensionName}/package`, keys, messages); |