From b344f434980621de2ddf35d5788c16a8399bc765 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Tue, 15 Feb 2022 16:27:08 +0100 Subject: Revert "linux: disable crash reporting in CI (#142572)" This reverts commit 7dbd7367dc96690ae1cae12f9d74191b3f21b6fe. --- scripts/test-integration.sh | 3 +-- scripts/test-remote-integration.sh | 3 +-- scripts/test.sh | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) (limited to 'scripts') diff --git a/scripts/test-integration.sh b/scripts/test-integration.sh index 418b6bb8a6c..2fb82e34740 100755 --- a/scripts/test-integration.sh +++ b/scripts/test-integration.sh @@ -8,8 +8,7 @@ else ROOT=$(dirname $(dirname $(readlink -f $0))) # --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm # partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory - # --disable-crash-reporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572) - LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disable-crash-reporter" + LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader" fi VSCODEUSERDATADIR=`mktemp -d 2>/dev/null` diff --git a/scripts/test-remote-integration.sh b/scripts/test-remote-integration.sh index d1029aaa277..39c36592e24 100755 --- a/scripts/test-remote-integration.sh +++ b/scripts/test-remote-integration.sh @@ -8,8 +8,7 @@ else ROOT=$(dirname $(dirname $(readlink -f $0))) # --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm # partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory - # --disable-crash-reporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572) - LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disable-crash-reporter" + LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader" fi VSCODEUSERDATADIR=`mktemp -d 2>/dev/null` diff --git a/scripts/test.sh b/scripts/test.sh index 4c3021d474d..14a72e09cc3 100755 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -8,8 +8,7 @@ else ROOT=$(dirname $(dirname $(readlink -f $0))) # --disable-dev-shm-usage --use-gl=swiftshader: when run on docker containers where size of /dev/shm # partition < 64MB which causes OOM failure for chromium compositor that uses the partition for shared memory - # --disableCrashReporter: TODO@electron this needs Electron 17 to work (https://github.com/microsoft/vscode/issues/142572) - LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader --disableCrashReporter" + LINUX_EXTRA_ARGS="--disable-dev-shm-usage --use-gl=swiftshader" fi cd $ROOT -- cgit v1.2.3