diff options
author | Min Huang <huangmin@microsoft.com> | 2022-04-13 10:19:52 +0300 |
---|---|---|
committer | Min Huang <huangmin@microsoft.com> | 2022-04-13 10:19:52 +0300 |
commit | cbce97b1406ecc2dd36af0f912736b8fa6fa7208 (patch) | |
tree | 31fd19aa204a0e98fc71100aa61df3d5353541cd | |
parent | d71b38e09cf56a4b8e209866ca7a7ec633a709c9 (diff) |
updatemh/function-pointers
-rw-r--r-- | mdoc/Mono.Documentation/Updater/DocumentationEnumerator.cs | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/mdoc/Mono.Documentation/Updater/DocumentationEnumerator.cs b/mdoc/Mono.Documentation/Updater/DocumentationEnumerator.cs index 3b950af4..3b710a98 100644 --- a/mdoc/Mono.Documentation/Updater/DocumentationEnumerator.cs +++ b/mdoc/Mono.Documentation/Updater/DocumentationEnumerator.cs @@ -141,8 +141,7 @@ namespace Mono.Documentation.Updater isRefType = true; // this will be the case for generic parameter types string paramType = GetReplacedString ( - // we need convert function pointer type back to "method" otherwise there will be a new member added. - pis[i].ParameterType is FunctionPointerType ? "method" : MDocUpdater.GetDocParameterType (pis[i].ParameterType), + MDocUpdater.GetDocParameterType (pis[i].ParameterType), typeParams, docTypeParams); // if magictypes, replace paramType to "classic value" ... so the comparison works @@ -154,6 +153,9 @@ namespace Mono.Documentation.Updater string xmlMemberType = member.Parameters[i]; + // After we support function pointers, "method" as type should be skipped and not be compared with current function pointer type. + if (xmlMemberType == "method") continue; + // TODO: take into account extension method reftype bool xmlIsRefType = xmlMemberType.Contains ('&'); bool refTypesMatch = isRefType == xmlIsRefType; |