diff options
author | Joel Martinez <joelmartinez@gmail.com> | 2015-09-05 00:27:10 +0300 |
---|---|---|
committer | Duncan Mak <duncanm@microsoft.com> | 2016-10-08 03:31:02 +0300 |
commit | d36148f791aaa277cf42668656961f94e297aeae (patch) | |
tree | c48112a4c70630ee4528a48b3500ed4e987fee3a /mdoc/Test/en.expected-dropns-delete | |
parent | ac5d5eac2e03b910d097aa5142af0dd5d6c4bf33 (diff) |
[mdoc] Follow up fix for member and type removal.
In supplement of the changes submitted in 09b97cba2e7c2d9c68830d55ff3d99c5f36eb439, there were
some additional edge cases that were not originally considered, and so this patch resolves these
additional issues. In particular, there was a bug in the `RemoveApiStyle` method that wasn't
checking the value of the `apistyle` attribute before removing it. This caused members to be
stripped of apistyle inadvertently.
There was an issue in the type removal code that caused
too many files to be removed. This patch adds additional checks to make sure that a file isn't
going to be removed if it contains members in the other style that shoulnd't be removed
Finally, there was an issue that arose after the aforementioned changes in the `OrderTypeAttributes`
method. It was somewhat counterintuitive, but it wasn't allowing the reordering of attributes
with the `.Remove` method (throwing an exception). Not entirely sure why this was happening,
but using the `.RemoveNamedItem` method worked around the issue.
Diffstat (limited to 'mdoc/Test/en.expected-dropns-delete')
-rw-r--r-- | mdoc/Test/en.expected-dropns-delete/MyFramework.MyNamespace/WillDelete.xml.remove | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/mdoc/Test/en.expected-dropns-delete/MyFramework.MyNamespace/WillDelete.xml.remove b/mdoc/Test/en.expected-dropns-delete/MyFramework.MyNamespace/WillDelete.xml.remove index 775b8aff..ac5394fb 100644 --- a/mdoc/Test/en.expected-dropns-delete/MyFramework.MyNamespace/WillDelete.xml.remove +++ b/mdoc/Test/en.expected-dropns-delete/MyFramework.MyNamespace/WillDelete.xml.remove @@ -14,9 +14,6 @@ <MemberSignature Language="C#" Value="public WillDelete ();" /> <MemberSignature Language="ILAsm" Value=".method public hidebysig specialname rtspecialname instance void .ctor() cil managed" /> <MemberType>Constructor</MemberType> - <AssemblyInfo apistyle="classic"> - <AssemblyVersion>0.0.0.0</AssemblyVersion> - </AssemblyInfo> <AssemblyInfo apistyle="unified"> <AssemblyVersion>0.0.0.0</AssemblyVersion> </AssemblyInfo> @@ -30,9 +27,6 @@ <MemberSignature Language="C#" Value="public string Name { get; set; }" /> <MemberSignature Language="ILAsm" Value=".property instance string Name" /> <MemberType>Property</MemberType> - <AssemblyInfo apistyle="classic"> - <AssemblyVersion>0.0.0.0</AssemblyVersion> - </AssemblyInfo> <AssemblyInfo apistyle="unified"> <AssemblyVersion>0.0.0.0</AssemblyVersion> </AssemblyInfo> |