Remove explicit .hiddens from x86_64 perlasm files.

This reverts the non-ARM portions of 97999919bbe85ab213d283e18e597e028f8685d1.
x86_64 perlasm already makes .globl imply .hidden. (Confusingly, ARM does not.)
Since we don't need it, revert those to minimize divergence with upstream.

Change-Id: I2d205cfb1183e65d4f18a62bde187d206b1a96de
Reviewed-on: https://boringssl-review.googlesource.com/3610
Reviewed-by: Adam Langley <agl@google.com>

5 files changed, 0 insertions, 33 deletions

diff --git a/crypto/aes/asm/aes-x86_64.pl b/crypto/aes/asm/aes-x86_64.pl
index f1afbfba..4b6e1b44 100644
--- a/crypto/aes/asm/aes-x86_64.pl
+++ b/crypto/aes/asm/aes-x86_64.pl
@@ -1283,7 +1283,6 @@ $code.=<<___;
 .align	16
 .globl asm_AES_set_encrypt_key
 .type  asm_AES_set_encrypt_key,\@function,3
-.hidden asm_AES_set_encrypt_key
 asm_AES_set_encrypt_key:
 	push	%rbx
 	push	%rbp
@@ -1549,7 +1548,6 @@ $code.=<<___;
 .align	16
 .globl asm_AES_set_decrypt_key
 .type  asm_AES_set_decrypt_key,\@function,3
-.hidden asm_AES_set_decrypt_key
 asm_AES_set_decrypt_key:
 	push	%rbx
 	push	%rbp
diff --git a/crypto/aes/asm/aesni-x86_64.pl b/crypto/aes/asm/aesni-x86_64.pl
index 918e1258..5f617463 100644
--- a/crypto/aes/asm/aesni-x86_64.pl
+++ b/crypto/aes/asm/aesni-x86_64.pl
@@ -256,7 +256,6 @@ ___
 $code.=<<___;
 .globl	${PREFIX}_encrypt
 .type	${PREFIX}_encrypt,\@abi-omnipotent
-.hidden	${PREFIX}_encrypt
 .align	16
 ${PREFIX}_encrypt:
 	movups	($inp),$inout0		# load input
@@ -270,7 +269,6 @@ $code.=<<___;
 
 .globl	${PREFIX}_decrypt
 .type	${PREFIX}_decrypt,\@abi-omnipotent
-.hidden	${PREFIX}_decrypt
 .align	16
 ${PREFIX}_decrypt:
 	movups	($inp),$inout0		# load input
@@ -584,7 +582,6 @@ if ($PREFIX eq "aesni") {
 $code.=<<___;
 .globl	aesni_ecb_encrypt
 .type	aesni_ecb_encrypt,\@function,5
-.hidden	aesni_ecb_encrypt
 .align	16
 aesni_ecb_encrypt:
 ___
@@ -909,7 +906,6 @@ my $bswap_mask="%xmm7";
 $code.=<<___;
 .globl	aesni_ccm64_encrypt_blocks
 .type	aesni_ccm64_encrypt_blocks,\@function,6
-.hidden	aesni_ccm64_encrypt_blocks
 .align	16
 aesni_ccm64_encrypt_blocks:
 ___
@@ -990,7 +986,6 @@ ___
 $code.=<<___;
 .globl	aesni_ccm64_decrypt_blocks
 .type	aesni_ccm64_decrypt_blocks,\@function,6
-.hidden	aesni_ccm64_decrypt_blocks
 .align	16
 aesni_ccm64_decrypt_blocks:
 ___
@@ -1105,7 +1100,6 @@ my $frame_size = 0x80 + ($win64?160:0);
 $code.=<<___;
 .globl	aesni_ctr32_encrypt_blocks
 .type	aesni_ctr32_encrypt_blocks,\@function,5
-.hidden	aesni_ctr32_encrypt_blocks
 .align	16
 aesni_ctr32_encrypt_blocks:
 	lea	(%rsp),%rax
@@ -1617,7 +1611,6 @@ my $frame_size = 0x70 + ($win64?160:0);
 $code.=<<___;
 .globl	aesni_xts_encrypt
 .type	aesni_xts_encrypt,\@function,6
-.hidden	aesni_xts_encrypt
 .align	16
 aesni_xts_encrypt:
 	lea	(%rsp),%rax
@@ -2052,7 +2045,6 @@ ___
 $code.=<<___;
 .globl	aesni_xts_decrypt
 .type	aesni_xts_decrypt,\@function,6
-.hidden	aesni_xts_decrypt
 .align	16
 aesni_xts_decrypt:
 	lea	(%rsp),%rax
@@ -2524,7 +2516,6 @@ my $inp_=$key_;
 $code.=<<___;
 .globl	${PREFIX}_cbc_encrypt
 .type	${PREFIX}_cbc_encrypt,\@function,6
-.hidden	${PREFIX}_cbc_encrypt
 .align	16
 ${PREFIX}_cbc_encrypt:
 	test	$len,$len		# check length
@@ -2982,7 +2973,6 @@ ___
 $code.=<<___;
 .globl	${PREFIX}_set_decrypt_key
 .type	${PREFIX}_set_decrypt_key,\@abi-omnipotent
-.hidden	${PREFIX}_set_decrypt_key
 .align	16
 ${PREFIX}_set_decrypt_key:
 	.byte	0x48,0x83,0xEC,0x08	# sub rsp,8
@@ -3033,7 +3023,6 @@ ___
 $code.=<<___;
 .globl	${PREFIX}_set_encrypt_key
 .type	${PREFIX}_set_encrypt_key,\@abi-omnipotent
-.hidden	${PREFIX}_set_encrypt_key
 .align	16
 ${PREFIX}_set_encrypt_key:
 __aesni_set_encrypt_key:
diff --git a/crypto/aes/asm/aesv8-armx.pl b/crypto/aes/asm/aesv8-armx.pl
index 1e3d6626..1e93f868 100644
--- a/crypto/aes/asm/aesv8-armx.pl
+++ b/crypto/aes/asm/aesv8-armx.pl
@@ -63,7 +63,6 @@ rcon:
 
 .globl	${prefix}_set_encrypt_key
 .type	${prefix}_set_encrypt_key,%function
-.hidden	${prefix}_set_encrypt_key
 .align	5
 ${prefix}_set_encrypt_key:
 .Lenc_key:
@@ -235,7 +234,6 @@ $code.=<<___;
 
 .globl	${prefix}_set_decrypt_key
 .type	${prefix}_set_decrypt_key,%function
-.hidden	${prefix}_set_decrypt_key
 .align	5
 ${prefix}_set_decrypt_key:
 ___
@@ -300,7 +298,6 @@ my ($rndkey0,$rndkey1,$inout)=map("q$_",(0..3));
 $code.=<<___;
 .globl	${prefix}_${dir}crypt
 .type	${prefix}_${dir}crypt,%function
-.hidden	${prefix}_${dir}crypt
 .align	5
 ${prefix}_${dir}crypt:
 	ldr	$rounds,[$key,#240]
@@ -345,7 +342,6 @@ my ($dat,$tmp,$rndzero_n_last)=($dat0,$tmp0,$tmp1);
 $code.=<<___;
 .globl	${prefix}_cbc_encrypt
 .type	${prefix}_cbc_encrypt,%function
-.hidden	${prefix}_cbc_encrypt
 .align	5
 ${prefix}_cbc_encrypt:
 ___
@@ -653,7 +649,6 @@ my ($dat,$tmp)=($dat0,$tmp0);
 $code.=<<___;
 .globl	${prefix}_ctr32_encrypt_blocks
 .type	${prefix}_ctr32_encrypt_blocks,%function
-.hidden	${prefix}_ctr32_encrypt_blocks
 .align	5
 ${prefix}_ctr32_encrypt_blocks:
 ___
diff --git a/crypto/aes/asm/bsaes-x86_64.pl b/crypto/aes/asm/bsaes-x86_64.pl
index 8c6e66a4..3f7d33c4 100644
--- a/crypto/aes/asm/bsaes-x86_64.pl
+++ b/crypto/aes/asm/bsaes-x86_64.pl
@@ -1049,7 +1049,6 @@ if (0 && !$win64) {	# following four functions are unsupported interface
 $code.=<<___;
 .globl	bsaes_enc_key_convert
 .type	bsaes_enc_key_convert,\@function,2
-.hidden	bsaes_enc_key_convert
 .align	16
 bsaes_enc_key_convert:
 	mov	240($inp),%r10d		# pass rounds
@@ -1063,7 +1062,6 @@ bsaes_enc_key_convert:
 
 .globl	bsaes_encrypt_128
 .type	bsaes_encrypt_128,\@function,4
-.hidden	bsaes_encrypt_128
 .align	16
 bsaes_encrypt_128:
 .Lenc128_loop:
@@ -1097,7 +1095,6 @@ bsaes_encrypt_128:
 
 .globl	bsaes_dec_key_convert
 .type	bsaes_dec_key_convert,\@function,2
-.hidden	bsaes_dec_key_convert
 .align	16
 bsaes_dec_key_convert:
 	mov	240($inp),%r10d		# pass rounds
@@ -1112,7 +1109,6 @@ bsaes_dec_key_convert:
 
 .globl	bsaes_decrypt_128
 .type	bsaes_decrypt_128,\@function,4
-.hidden	bsaes_decrypt_128
 .align	16
 bsaes_decrypt_128:
 .Ldec128_loop:
@@ -1158,7 +1154,6 @@ if ($ecb) {
 $code.=<<___;
 .globl	bsaes_ecb_encrypt_blocks
 .type	bsaes_ecb_encrypt_blocks,\@abi-omnipotent
-.hidden	bsaes_ecb_encrypt_blocks
 .align	16
 bsaes_ecb_encrypt_blocks:
 	mov	%rsp, %rax
@@ -1360,7 +1355,6 @@ $code.=<<___;
 
 .globl	bsaes_ecb_decrypt_blocks
 .type	bsaes_ecb_decrypt_blocks,\@abi-omnipotent
-.hidden	bsaes_ecb_decrypt_blocks
 .align	16
 bsaes_ecb_decrypt_blocks:
 	mov	%rsp, %rax
@@ -1566,7 +1560,6 @@ $code.=<<___;
 .extern	asm_AES_cbc_encrypt
 .globl	bsaes_cbc_encrypt
 .type	bsaes_cbc_encrypt,\@abi-omnipotent
-.hidden	bsaes_cbc_encrypt
 .align	16
 bsaes_cbc_encrypt:
 ___
@@ -1854,7 +1847,6 @@ $code.=<<___;
 
 .globl	bsaes_ctr32_encrypt_blocks
 .type	bsaes_ctr32_encrypt_blocks,\@abi-omnipotent
-.hidden	bsaes_ctr32_encrypt_blocks
 .align	16
 bsaes_ctr32_encrypt_blocks:
 	mov	%rsp, %rax
@@ -2096,7 +2088,6 @@ $arg6=~s/d$//;
 $code.=<<___;
 .globl	bsaes_xts_encrypt
 .type	bsaes_xts_encrypt,\@abi-omnipotent
-.hidden	bsaes_xts_encrypt
 .align	16
 bsaes_xts_encrypt:
 	mov	%rsp, %rax
@@ -2478,7 +2469,6 @@ $code.=<<___;
 
 .globl	bsaes_xts_decrypt
 .type	bsaes_xts_decrypt,\@abi-omnipotent
-.hidden	bsaes_xts_decrypt
 .align	16
 bsaes_xts_decrypt:
 	mov	%rsp, %rax
diff --git a/crypto/aes/asm/vpaes-x86_64.pl b/crypto/aes/asm/vpaes-x86_64.pl
index a647b920..f2ef318f 100644
--- a/crypto/aes/asm/vpaes-x86_64.pl
+++ b/crypto/aes/asm/vpaes-x86_64.pl
@@ -671,7 +671,6 @@ _vpaes_schedule_mangle:
 #
 .globl	${PREFIX}_set_encrypt_key
 .type	${PREFIX}_set_encrypt_key,\@function,3
-.hidden	${PREFIX}_set_encrypt_key
 .align	16
 ${PREFIX}_set_encrypt_key:
 ___
@@ -720,7 +719,6 @@ $code.=<<___;
 
 .globl	${PREFIX}_set_decrypt_key
 .type	${PREFIX}_set_decrypt_key,\@function,3
-.hidden	${PREFIX}_set_decrypt_key
 .align	16
 ${PREFIX}_set_decrypt_key:
 ___
@@ -774,7 +772,6 @@ $code.=<<___;
 
 .globl	${PREFIX}_encrypt
 .type	${PREFIX}_encrypt,\@function,3
-.hidden	${PREFIX}_encrypt
 .align	16
 ${PREFIX}_encrypt:
 ___
@@ -818,7 +815,6 @@ $code.=<<___;
 
 .globl	${PREFIX}_decrypt
 .type	${PREFIX}_decrypt,\@function,3
-.hidden	${PREFIX}_decrypt
 .align	16
 ${PREFIX}_decrypt:
 ___
@@ -868,7 +864,6 @@ my ($inp,$out,$len,$key,$ivp,$enc)=("%rdi","%rsi","%rdx","%rcx","%r8","%r9");
 $code.=<<___;
 .globl	${PREFIX}_cbc_encrypt
 .type	${PREFIX}_cbc_encrypt,\@function,6
-.hidden	${PREFIX}_cbc_encrypt
 .align	16
 ${PREFIX}_cbc_encrypt:
 	xchg	$key,$len