diff options
| author | Piotr Sikora <piotrsikora@google.com> | 2015-11-11 08:20:12 +0300 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2015-11-12 01:20:04 +0300 |
| commit | d386394aad8a9c41f27cb9bef83dbc03b5aece97 (patch) | |
| tree | ddfedc001f17e2be2d0f970153a638afb8043dab /crypto/bio | |
| parent | ef14b2d86e4ce24d7adc2d7948b5372bc3b62c33 (diff) | |
Test for underflow before subtraction.
Found with -Wtype-limits.
Change-Id: I41cdbb7e6564b715dfe445877a89594371fdeef0
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Reviewed-on: https://boringssl-review.googlesource.com/6462
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'crypto/bio')
| -rw-r--r-- | crypto/bio/pair.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/bio/pair.c b/crypto/bio/pair.c index 6f788903..fba4be2c 100644 --- a/crypto/bio/pair.c +++ b/crypto/bio/pair.c @@ -256,8 +256,8 @@ int BIO_zero_copy_get_read_buf_done(BIO* bio, size_t bytes_read) { return 0; } + assert(peer_b->len >= bytes_read); peer_b->len -= bytes_read; - assert(peer_b->len >= 0); assert(peer_b->offset + bytes_read <= peer_b->size); /* Move read offset. If zero_copy_write_lock == 1 we must advance the |