diff options
| author | Adam Langley <agl@google.com> | 2015-01-31 04:08:37 +0300 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2015-02-02 22:14:15 +0300 |
| commit | 2b2d66d4094e5c25789ce68310d86192c377c63b (patch) | |
| tree | 0037574fca9fad9755016ccc0f8e4ddb0f978a59 /crypto/chacha | |
| parent | efed2210e8e0c6b3db6c63e354f0c9b67673c712 (diff) | |
Remove string.h from base.h.
Including string.h in base.h causes any file that includes a BoringSSL
header to include string.h. Generally this wouldn't be a problem,
although string.h might slow down the compile if it wasn't otherwise
needed. However, it also causes problems for ipsec-tools in Android
because OpenSSL didn't have this behaviour.
This change removes string.h from base.h and, instead, adds it to each
.c file that requires it.
Change-Id: I5968e50b0e230fd3adf9b72dd2836e6f52d6fb37
Reviewed-on: https://boringssl-review.googlesource.com/3200
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'crypto/chacha')
| -rw-r--r-- | crypto/chacha/chacha_generic.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/crypto/chacha/chacha_generic.c b/crypto/chacha/chacha_generic.c index 3e73d8e4..31cf4f02 100644 --- a/crypto/chacha/chacha_generic.c +++ b/crypto/chacha/chacha_generic.c @@ -16,8 +16,11 @@ #include <openssl/chacha.h> +#include <string.h> + #include <openssl/cpu.h> + #if defined(OPENSSL_WINDOWS) || (!defined(OPENSSL_X86_64) && !defined(OPENSSL_X86)) || !defined(__SSE2__) /* sigma contains the ChaCha constants, which happen to be an ASCII string. */ |