diff options
| author | Adam Langley <agl@google.com> | 2016-06-16 20:43:39 +0300 |
|---|---|---|
| committer | David Benjamin <davidben@google.com> | 2016-06-16 20:48:08 +0300 |
| commit | 3cab5572b1fcf5a8f6018529dc30dc8d21b2a4bd (patch) | |
| tree | a97daac60890f7b1dca7655d6cb558284fde8235 /crypto/newhope | |
| parent | 13603a8399cd50bdc476cf46ac8c81244aadbad9 (diff) | |
Don't align NEWPOLY_POLY.
The alignas in NEWPOLY_POLY told the compiler that it could assume a
certain alignment. However, values were allocated with malloc with no
specific alignment.
We could try and allocate aligned memory but the alignment doesn't have
a performance impact (on x86-64) so this is the simpler change. (Also,
Windows doesn't have |posix_memalign|. The cloest thing is
_alligned_alloc but then one has to use a special free function.)
Change-Id: I53955a88862160c02aa5436d991b1b797c3c17db
Reviewed-on: https://boringssl-review.googlesource.com/8315
Reviewed-by: David Benjamin <davidben@google.com>
Diffstat (limited to 'crypto/newhope')
| -rw-r--r-- | crypto/newhope/internal.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/newhope/internal.h b/crypto/newhope/internal.h index efc5adf8..eb170c06 100644 --- a/crypto/newhope/internal.h +++ b/crypto/newhope/internal.h @@ -32,7 +32,7 @@ /* Polynomial coefficients in unpacked form. */ struct newhope_poly_st { - alignas(32) uint16_t coeffs[PARAM_N]; + uint16_t coeffs[PARAM_N]; }; /* SEED_LENGTH is the length of the AES-CTR seed used to derive a polynomial. */ |