diff options
| author | Adam Langley <agl@google.com> | 2015-02-20 04:48:29 +0300 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2015-02-21 00:24:01 +0300 |
| commit | 97999919bbe85ab213d283e18e597e028f8685d1 (patch) | |
| tree | d1410b26a832dae606ea255ad5dce6b0b449cce7 /crypto/sha | |
| parent | bcc4e2304123169af6acd1b842509430e79fd390 (diff) | |
Hide all asm symbols.
We are leaking asm symbols in Android builds because the asm code isn't
affected by -fvisibility=hidden. This change hides all asm symbols.
This assumes that no asm symbols are public API and that should be true.
Some points to note:
In crypto/rc4/asm/rc4-md5-x86_64.pl there are |RC4_set_key| and
|RC4_options| functions which aren't getting marked as hidden. That's
because those functions aren't actually ever generated. (I'm just trying
to minimise drift with upstream here.)
In crypto/rc4/asm/rc4-x86_64.pl there's |RC4_options| which is "public"
API, except that we've never had it in the header files. So I've just
deleted it. Since we have an internal caller, we'll probably have to put
it back in the future, but it can just be done in rc4.c to save
problems.
BUG=448386
Change-Id: I3846617a0e3d73ec9e5ec3638a53364adbbc6260
Reviewed-on: https://boringssl-review.googlesource.com/3520
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'crypto/sha')
| -rw-r--r-- | crypto/sha/asm/sha1-armv8.pl | 1 | ||||
| -rw-r--r-- | crypto/sha/asm/sha512-armv8.pl | 1 | ||||
| -rw-r--r-- | crypto/sha/asm/sha512-x86_64.pl | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/crypto/sha/asm/sha1-armv8.pl b/crypto/sha/asm/sha1-armv8.pl index deb1238d..a8efe4ff 100644 --- a/crypto/sha/asm/sha1-armv8.pl +++ b/crypto/sha/asm/sha1-armv8.pl @@ -156,6 +156,7 @@ $code.=<<___; .globl sha1_block_data_order .type sha1_block_data_order,%function +.hidden sha1_block_data_order .align 6 sha1_block_data_order: ldr x16,.LOPENSSL_armcap_P diff --git a/crypto/sha/asm/sha512-armv8.pl b/crypto/sha/asm/sha512-armv8.pl index 5a9c8129..570b0843 100644 --- a/crypto/sha/asm/sha512-armv8.pl +++ b/crypto/sha/asm/sha512-armv8.pl @@ -154,6 +154,7 @@ $code.=<<___; .globl $func .type $func,%function +.hidden $func .align 6 $func: ___ diff --git a/crypto/sha/asm/sha512-x86_64.pl b/crypto/sha/asm/sha512-x86_64.pl index 6660a88b..93f0c9c2 100644 --- a/crypto/sha/asm/sha512-x86_64.pl +++ b/crypto/sha/asm/sha512-x86_64.pl @@ -258,6 +258,7 @@ $code=<<___; .extern OPENSSL_ia32cap_P .globl $func .type $func,\@function,3 +.hidden $func .align 16 $func: ___ |