diff options
| author | David Benjamin <davidben@google.com> | 2016-08-30 06:14:17 +0300 |
|---|---|---|
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | 2016-08-30 18:43:35 +0300 |
| commit | 163c95691a0e6f115d0b51db36325e77fae7f018 (patch) | |
| tree | 30be9b879a23b4856d73f9072579b8dc66001cff /crypto | |
| parent | 147f1c468c937e0d05c9d1168f709c316a0697d2 (diff) | |
Forbid EMS from changing during renegotation.
Changing parameters on renegotiation makes all our APIs confusing. This
one has no reason to change, so lock it down. In particular, our
preference to forbid Token Binding + renego may be overridden at the
IETF, even though it's insane. Loosening it will be a bit less of a
headache if EMS can't change.
https://www.ietf.org/mail-archive/web/unbearable/current/msg00690.html
claims that this is already in the specification and enforced by NSS. I
can't find anything to this effect in the specification. It just says
the client MUST disable renegotiation when EMS is missing, which is
wishful thinking. At a glance, NSS doesn't seem to check, though I could
be misunderstanding the code.
Nonetheless, locking this down is a good idea anyway. Accurate or not,
take the email as an implicit endorsement of this from Mozilla.
Change-Id: I236b05991d28bed199763dcf2f47bbfb9d0322d7
Reviewed-on: https://boringssl-review.googlesource.com/10721
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/err/ssl.errordata | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/crypto/err/ssl.errordata b/crypto/err/ssl.errordata index c08c5d27..bca49316 100644 --- a/crypto/err/ssl.errordata +++ b/crypto/err/ssl.errordata @@ -109,6 +109,7 @@ SSL,197,PSK_NO_SERVER_CB SSL,198,READ_TIMEOUT_EXPIRED SSL,199,RECORD_LENGTH_MISMATCH SSL,200,RECORD_TOO_LARGE +SSL,263,RENEGOTIATION_EMS_MISMATCH SSL,201,RENEGOTIATION_ENCODING_ERR SSL,202,RENEGOTIATION_MISMATCH SSL,203,REQUIRED_CIPHER_MISSING |