diff options
| author | David Benjamin <davidben@google.com> | 2016-06-09 01:31:42 +0300 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2016-06-09 22:49:03 +0300 |
| commit | 2446db0f52b8697f3e131db3315de8a66fd9e0fe (patch) | |
| tree | 0d948b5cf18dbd51154d2f12b68f1d91b629e643 /include/openssl/aead.h | |
| parent | 1a01e1fc88968c4db023f38967f9e81a8c42a15d (diff) | |
Require in == out for in-place encryption.
While most of OpenSSL's assembly allows out < in too, some of it doesn't.
Upstream seems to not consider this a problem (or, at least, they're failing to
make a decision on whether it is a problem, so we should assume they'll stay
their course). Accordingly, require aliased buffers to exactly align so we
don't have to keep chasing this down.
Change-Id: I00eb3df3e195b249116c68f7272442918d7077eb
Reviewed-on: https://boringssl-review.googlesource.com/8231
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'include/openssl/aead.h')
| -rw-r--r-- | include/openssl/aead.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/openssl/aead.h b/include/openssl/aead.h index d9a640c3..7895825c 100644 --- a/include/openssl/aead.h +++ b/include/openssl/aead.h @@ -226,7 +226,7 @@ OPENSSL_EXPORT void EVP_AEAD_CTX_cleanup(EVP_AEAD_CTX *ctx); * insufficient, zero will be returned. (In this case, |*out_len| is set to * zero.) * - * If |in| and |out| alias then |out| must be <= |in|. */ + * If |in| and |out| alias then |out| must be == |in|. */ OPENSSL_EXPORT int EVP_AEAD_CTX_seal(const EVP_AEAD_CTX *ctx, uint8_t *out, size_t *out_len, size_t max_out_len, const uint8_t *nonce, size_t nonce_len, @@ -251,7 +251,7 @@ OPENSSL_EXPORT int EVP_AEAD_CTX_seal(const EVP_AEAD_CTX *ctx, uint8_t *out, * insufficient, zero will be returned. (In this case, |*out_len| is set to * zero.) * - * If |in| and |out| alias then |out| must be <= |in|. */ + * If |in| and |out| alias then |out| must be == |in|. */ OPENSSL_EXPORT int EVP_AEAD_CTX_open(const EVP_AEAD_CTX *ctx, uint8_t *out, size_t *out_len, size_t max_out_len, const uint8_t *nonce, size_t nonce_len, |