diff options
| author | David Benjamin <davidben@chromium.org> | 2014-08-04 23:06:28 +0400 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2014-08-05 01:11:21 +0400 |
| commit | aa4efe76694725ad242f763d004d538ccbba6533 (patch) | |
| tree | 2db5f66c13ad7e177f18539ccf5b0a90c2796f85 /include/openssl/bio.h | |
| parent | a59fbb0eddf6eb129ab994a5331bf77ab8721eb0 (diff) | |
Fix BIO_printf crash on Mac.
A single va_list may not be used twice. Nothing calls BIO_vprintf and it just
(v)snprintfs into a buffer anyway, so remove it. If it's actually needed, we
can fiddle with va_copy and the lack of it in C89 later, but anything that
actually cares can just assemble the output externally.
Add a test in bio_test.c.
BUG=399546
Change-Id: Ia40a68b31cb5984d817e9c55351f49d9d6c964c1
Reviewed-on: https://boringssl-review.googlesource.com/1391
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'include/openssl/bio.h')
| -rw-r--r-- | include/openssl/bio.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/openssl/bio.h b/include/openssl/bio.h index 962b2cf4..7aaa51d8 100644 --- a/include/openssl/bio.h +++ b/include/openssl/bio.h @@ -305,9 +305,6 @@ OPENSSL_EXPORT void BIO_copy_next_retry(BIO *bio); #endif OPENSSL_EXPORT int BIO_printf(BIO *bio, const char *format, ...) __bio_h__attr__((__format__(__printf__, 2, 3))); - -OPENSSL_EXPORT int BIO_vprintf(BIO *bio, const char *format, va_list args) - __bio_h__attr__((__format__(__printf__, 2, 0))); #undef __bio_h__attr__ |