diff options
| author | David Benjamin <davidben@chromium.org> | 2015-01-11 07:37:17 +0300 |
|---|---|---|
| committer | Adam Langley <agl@google.com> | 2015-01-13 01:29:10 +0300 |
| commit | 95e18c52f252a8069a97cbb4a9ce6af668224981 (patch) | |
| tree | d80100dd07ea83983f4f129638808bfec2a580be /include/openssl/dsa.h | |
| parent | ca9a538aa0f2ebdd261783efa032e69a2ea17fbc (diff) | |
Fix DER checks for DSA_check_signature and add tests.
DSA_verify and DSA_check_signature didn't share a codepath, so the fix was only
applied to the former. Implement verify in terms of check_signature and add
tests for bad DER variants.
Change-Id: I6577f96b13b57fc89a5308bd8a7c2318defa7ee1
Reviewed-on: https://boringssl-review.googlesource.com/2820
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'include/openssl/dsa.h')
| -rw-r--r-- | include/openssl/dsa.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/openssl/dsa.h b/include/openssl/dsa.h index 5e71ae2d..8a182c28 100644 --- a/include/openssl/dsa.h +++ b/include/openssl/dsa.h @@ -160,7 +160,7 @@ OPENSSL_EXPORT DSA_SIG *DSA_do_sign(const uint8_t *digest, size_t digest_len, OPENSSL_EXPORT int DSA_do_verify(const uint8_t *digest, size_t digest_len, DSA_SIG *sig, const DSA *dsa); -/* DSA_check_signature sets |*out_valid| to zero. Then it verifies that |sig| +/* DSA_do_check_signature sets |*out_valid| to zero. Then it verifies that |sig| * is a valid signature, by the public key in |dsa| of the hash in |digest| * and, if so, it sets |*out_valid| to one. * |