Add outgoing messages to the handshake hash at set_handshake_header.

This avoids needing a should_add_to_finished_hash boolean on do_write. The
logic in do_write was a little awkward because do_write would be called
multiple times if the write took several iterations. This also gets complex if
DTLS retransmits are involved. (At a glance, it's not obvious the
BIO_CTRL_DGRAM_MTU_EXCEEDED case actually works.)

Doing it as the handshake message is being prepared avoids this concern. It
also gives a natural point for the extended master secret logic which needs to
do work after the finished hash has been sampled.

As a bonus, we can remove s->d1->retransmitting which was only used to deal
with this issue.

Change-Id: Ifedf23ee4a6c5e08f960d296a6eb1f337a16dc7a
Reviewed-on: https://boringssl-review.googlesource.com/2604
Reviewed-by: Adam Langley <agl@google.com>

1 files changed, 0 insertions, 1 deletions

diff --git a/include/openssl/dtls1.h b/include/openssl/dtls1.h
index d3a3b55b..57337f63 100644
--- a/include/openssl/dtls1.h
+++ b/include/openssl/dtls1.h
@@ -230,7 +230,6 @@ typedef struct dtls1_state_st
 	unsigned char handshake_fragment[DTLS1_HM_HEADER_LENGTH];
 	unsigned int handshake_fragment_len;
 
-	unsigned int retransmitting;
 	unsigned int change_cipher_spec_ok;
 	} DTLS1_STATE;