diff options
author | David Benjamin <davidben@chromium.org> | 2015-04-03 09:39:21 +0300 |
---|---|---|
committer | Adam Langley <agl@google.com> | 2015-04-06 23:49:00 +0300 |
commit | f8ba2855354cf8a6b5a4664a1c93be889b8e2890 (patch) | |
tree | 93e7c4c904b04fb841ef27d477e2a6b35e45c6f8 /ssl/d1_both.c | |
parent | cfd248b7f6be0a3a8a21d96b21a61203ce24d1c8 (diff) |
Remove redundant SSL_READING lines after ssl_read_bytes.
These are redundant with the lower level ones in s3_pkt.c just before BIO_read.
Only the operation which actually failed an operation on the BIO should set
the wait state.
Not all failure paths in ssl3_read_bytes and dtls1_read_bytes set SSL_READING,
but those that don't leave the BIO in a retry state, so SSL_READING doesn't
matter.
Change-Id: I2ae064ecc8b2946cc8ae8f724be09dfe49e077b5
Reviewed-on: https://boringssl-review.googlesource.com/4230
Reviewed-by: Adam Langley <agl@google.com>
Diffstat (limited to 'ssl/d1_both.c')
-rw-r--r-- | ssl/d1_both.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ssl/d1_both.c b/ssl/d1_both.c index bcf86404..40044995 100644 --- a/ssl/d1_both.c +++ b/ssl/d1_both.c @@ -489,7 +489,6 @@ static int dtls1_process_fragment(SSL *s) { int ret = s->method->ssl_read_bytes(s, SSL3_RT_HANDSHAKE, header, DTLS1_HM_HEADER_LENGTH, 0); if (ret <= 0) { - s->rwstate = SSL_READING; return ret; } if (ret != DTLS1_HM_HEADER_LENGTH) { |