From 0687bdfc12e7ce5832610465d12c69040d1c714b Mon Sep 17 00:00:00 2001 From: Brian Smith Date: Sun, 17 Jan 2016 09:18:26 -1000 Subject: Fix -Wformat-nonliteral violation in ssl_cipher.c. Besides avoiding the -Wformat-nonliteral warning, it is easier to review (changes to) the code when the format string is passed to the function as a literal. Change-Id: I5093ad4494d5ebeea3f2671509b916cd6c5fb173 Reviewed-on: https://boringssl-review.googlesource.com/6908 Reviewed-by: David Benjamin --- ssl/ssl_cipher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'ssl/ssl_cipher.c') diff --git a/ssl/ssl_cipher.c b/ssl/ssl_cipher.c index 77fa8fa6..ba738488 100644 --- a/ssl/ssl_cipher.c +++ b/ssl/ssl_cipher.c @@ -1804,7 +1804,6 @@ const char *SSL_CIPHER_description(const SSL_CIPHER *cipher, char *buf, int len) { const char *kx, *au, *enc, *mac; uint32_t alg_mkey, alg_auth, alg_enc, alg_mac; - static const char *format = "%-23s Kx=%-8s Au=%-4s Enc=%-9s Mac=%-4s\n"; alg_mkey = cipher->algorithm_mkey; alg_auth = cipher->algorithm_auth; @@ -1928,7 +1927,8 @@ const char *SSL_CIPHER_description(const SSL_CIPHER *cipher, char *buf, return "Buffer too small"; } - BIO_snprintf(buf, len, format, cipher->name, kx, au, enc, mac); + BIO_snprintf(buf, len, "%-23s Kx=%-8s Au=%-4s Enc=%-9s Mac=%-4s\n", + cipher->name, kx, au, enc, mac); return buf; } -- cgit v1.2.3