diff options
| author | Arkadiy Shapkin <ashapkin@artec-group.com> | 2013-03-17 04:46:46 +0400 |
|---|---|---|
| committer | Arkadiy Shapkin <ashapkin@artec-group.com> | 2013-03-18 03:30:26 +0400 |
| commit | 10c06114cbb1c384b7de3cca6d6601ee750f5178 (patch) | |
| tree | 05b4c66610443dd41b50114480da9e8b7e99a123 /src/mwindow.c | |
| parent | a5f6138407efb6d8866fe8de5aac13454aefcd82 (diff) | |
Several warnings detected by static code analyzer fixed
Implicit type conversion argument of function to size_t type
Suspicious sequence of types castings: size_t -> int -> size_t
Consider reviewing the expression of the 'A = B == C' kind. The expression is calculated as following: 'A = (B == C)'
Unsigned type is never < 0
Diffstat (limited to 'src/mwindow.c')
| -rw-r--r-- | src/mwindow.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/mwindow.c b/src/mwindow.c index cb2ef78b0..b35503d46 100644 --- a/src/mwindow.c +++ b/src/mwindow.c @@ -33,7 +33,7 @@ static git_mwindow_ctl mem_ctl; void git_mwindow_free_all(git_mwindow_file *mwf) { git_mwindow_ctl *ctl = &mem_ctl; - unsigned int i; + size_t i; if (git_mutex_lock(&git__mwindow_mutex)) { giterr_set(GITERR_THREAD, "unable to lock mwindow mutex"); @@ -115,7 +115,7 @@ static void git_mwindow_scan_lru( static int git_mwindow_close_lru(git_mwindow_file *mwf) { git_mwindow_ctl *ctl = &mem_ctl; - unsigned int i; + size_t i; git_mwindow *lru_w = NULL, *lru_l = NULL, **list = &mwf->windows; /* FIXME: Does this give us any advantage? */ @@ -288,7 +288,7 @@ void git_mwindow_file_deregister(git_mwindow_file *mwf) { git_mwindow_ctl *ctl = &mem_ctl; git_mwindow_file *cur; - unsigned int i; + size_t i; if (git_mutex_lock(&git__mwindow_mutex)) return; |