error-handling: Repository

This also includes droping `git_buf_lasterror` because it makes no sense
in the new system. Note that in most of the places were it has been
dropped, the code needs cleanup. I.e. GIT_ENOMEM is going away, so
instead it should return a generic `-1` and obviously not throw
anything.

1 files changed, 2 insertions, 3 deletions

diff --git a/src/tag.c b/src/tag.c
index 6076eb6e8..a5089e71c 100644
--- a/src/tag.c
+++ b/src/tag.c
@@ -193,10 +193,9 @@ static int write_tag_annotation(
 	git_buf_putc(&tag, '\n');
 	git_buf_puts(&tag, message);
 
-	error = git_buf_lasterror(&tag);
-	if (error < GIT_SUCCESS) {
+	if (git_buf_oom(&tag)) {
 		git_buf_free(&tag);
-		return git__rethrow(error, "Not enough memory to build the tag data");
+		return git__throw(GIT_ENOMEM, "Not enough memory to build the tag data");
 	}
 
 	error = git_repository_odb__weakptr(&odb, repo);