diff options
author | Russell Belfer <arrbee@arrbee.com> | 2012-03-01 00:04:59 +0400 |
---|---|---|
committer | Russell Belfer <arrbee@arrbee.com> | 2012-03-03 03:51:55 +0400 |
commit | 854eccbb2d86c2910f9d98dc52f9ebd0e37c262a (patch) | |
tree | b22048a02480598477cde9c41fc16d3967226d6b /src/transport.c | |
parent | 74fa4bfae37e9d7c9e35550c881b114d7a83c4fa (diff) |
Clean up GIT_UNUSED macros on all platforms
It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5
did not fix the GIT_USUSED behavior on all platforms. This commit
walks through and really cleans things up more thoroughly, getting
rid of the unnecessary stuff.
To remove the use of some GIT_UNUSED, I ended up adding a couple
of new iterators for hashtables that allow you to iterator just
over keys or just over values.
In making this change, I found a bug in the clar tests (where we
were doing *count++ but meant to do (*count)++ to increment the
value). I fixed that but then found the test failing because it
was not really using an empty repo. So, I took some of the code
that I wrote for iterator testing and moved it to clar_helpers.c,
then made use of that to make it easier to open fixtures on a
per test basis even within a single test file.
Diffstat (limited to 'src/transport.c')
-rw-r--r-- | src/transport.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/transport.c b/src/transport.c index 672eb6e8a..785ddc35d 100644 --- a/src/transport.c +++ b/src/transport.c @@ -43,9 +43,9 @@ static git_transport_cb transport_find_fn(const char *url) * Public API * **************/ -int git_transport_dummy(git_transport **GIT_UNUSED(transport)) +int git_transport_dummy(git_transport **transport) { - GIT_UNUSED_ARG(transport); + GIT_UNUSED(transport); return git__throw(GIT_ENOTIMPLEMENTED, "This protocol isn't implemented. Sorry"); } |