diff options
| author | Mike Voorhees <michaelv@unity3d.com> | 2017-05-10 21:45:57 +0300 |
|---|---|---|
| committer | Marek Safar <marek.safar@gmail.com> | 2017-05-16 14:58:33 +0300 |
| commit | 6f93b07e7b8a8d24a09464e377a12065572237ad (patch) | |
| tree | 7aad221cb29ae66803579d2c3ce760fa30dcce6d /linker/Tests/Mono.Linker.Tests.Cases.Expectations/Mono.Linker.Tests.Cases.Expectations.csproj | |
| parent | 7785fe94cb5b69acd7ce4a0a68231521528a44f8 (diff) | |
Make assembly and module attribute marking slightly less conservative.
Currently we mark everything. With this change we will not mark assembly and module attributes when their defining module has not been marked after processing all types.
This fixes the test ReferencesAreRemovedWhenAllUsagesAreRemoved when ran against the .NET Framework. When this test was ran against the .NET Framework, System.dll was being kept around because of the assembly attribute BitmapSuffixInSatelliteAssemblyAttribute, which is itself defined in System.dll.
Add a command line option to disable the blacklist step
Fixed bug with ResultChecker treating [RemovedAssembly] the same
as [KeptAssembly]
For the test cases, disable options that tend to pollute the linked output
with a bunch of preservations that are not needed for our very narrow test cases
I did not write a unit test for this case because (a) it would be tricky to do at the moment and (b) we are overly conservative with attributes as a whole and attribute linking need to be reviewed. When that happens, we can pin down the exact behavior we want. The goal of this PR is to get ReferencesAreRemovedWhenAllUsagesAreRemoved passing.
Add Il8n and Blacklist option attributes.
Only disable these things during the test that needs to
Diffstat (limited to 'linker/Tests/Mono.Linker.Tests.Cases.Expectations/Mono.Linker.Tests.Cases.Expectations.csproj')
| -rw-r--r-- | linker/Tests/Mono.Linker.Tests.Cases.Expectations/Mono.Linker.Tests.Cases.Expectations.csproj | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/linker/Tests/Mono.Linker.Tests.Cases.Expectations/Mono.Linker.Tests.Cases.Expectations.csproj b/linker/Tests/Mono.Linker.Tests.Cases.Expectations/Mono.Linker.Tests.Cases.Expectations.csproj index d330e6c40..2ae41786a 100644 --- a/linker/Tests/Mono.Linker.Tests.Cases.Expectations/Mono.Linker.Tests.Cases.Expectations.csproj +++ b/linker/Tests/Mono.Linker.Tests.Cases.Expectations/Mono.Linker.Tests.Cases.Expectations.csproj @@ -50,6 +50,8 @@ <Compile Include="Assertions\RemovedTypeInAssemblyAttribute.cs" /> <Compile Include="Metadata\BaseMetadataAttribute.cs" /> <Compile Include="Metadata\CoreLinkAttribute.cs" /> + <Compile Include="Metadata\IncludeBlacklistStepAttribute.cs" /> + <Compile Include="Metadata\Il8nAttribute.cs" /> <Compile Include="Metadata\NotATestCaseAttribute.cs" /> <Compile Include="Metadata\ReferenceAttribute.cs" /> <Compile Include="Metadata\SandboxDependencyAttribute.cs" /> |