Roslyn analyzer improvements (#1622)

* Add supported diagnostics for when we use Url named argument
* Add support for Expected Warning
* Use single format for Resource file
* Dont execute test that used another diagnostic id that is not 2026
* Change formats in the linker for setters and getters to match C# format
* Use GetSignature in method instead of ToString()

1 files changed, 13 insertions, 2 deletions

diff --git a/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs b/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
index 339da78a2..d4024f24f 100644
--- a/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
+++ b/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
@@ -924,6 +924,8 @@ namespace Mono.Linker.Tests.TestCasesRunner
 			}
 
 			fullName += "::" + memberName;
+			if (memberName.EndsWith (".get") || memberName.EndsWith (".set"))
+				return fullName;
 			if (parameterTypes != null) {
 				fullName += "(" + string.Join (",", parameterTypes.Select (t => t.Value.ToString ())) + ")";
 			}
@@ -981,7 +983,10 @@ namespace Mono.Linker.Tests.TestCasesRunner
 
 				string fullName = memberDefinition.DeclaringType.FullName + "::";
 				if (memberDefinition is MethodDefinition method) {
-					fullName += method.GetSignature ();
+					if (method.IsSetter || method.IsGetter)
+						fullName += method.IsSetter ? method.Name.Substring (4) + ".set" : method.Name.Substring (4) + ".get";
+					else
+						fullName += method.GetSignature ();
 				} else {
 					fullName += memberDefinition.Name;
 				}
@@ -991,7 +996,13 @@ namespace Mono.Linker.Tests.TestCasesRunner
 				string type = param.ParameterType.FullName;
 				return $"{type}::{param.Name}";
 			} else if (member is MethodReturnType returnType) {
-				return returnType.Method.ToString ();
+				MethodDefinition method = (MethodDefinition) returnType.Method;
+				string fullName = method.ReturnType + " " + method.DeclaringType.FullName + "::";
+				if (method.IsSetter || method.IsGetter)
+					fullName += method.IsSetter ? method.Name.Substring (4) + ".set" : method.Name.Substring (4) + ".get";
+				else
+					fullName += method.GetSignature ();
+				return fullName;
 			}
 
 			throw new NotImplementedException ($"Getting the full member name has not been implemented for {member}");