Adjust how tests are asserted

We are hitting ever more complex scenarios in our linker.  I'm finding that I'd rather know that the IL was valid before worrying about getting all the types, methods, etc correctly annotated with [Kept] attributes.

In our linker test framework we have extra attributes to allow for the cases to be executed and the output asserted.  `InitialChecking` will be the place where we do that.  Again, I'd rather see these failures first before I invest the time correctly annotating the kept attributes.

1 files changed, 12 insertions, 7 deletions

diff --git a/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs b/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
index ea3eaf950..1280a57f9 100644
--- a/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
+++ b/test/Mono.Linker.Tests/TestCasesRunner/ResultChecker.cs
@@ -49,20 +49,17 @@ namespace Mono.Linker.Tests.TestCasesRunner {
 			try
 			{
 				var original = ResolveOriginalsAssembly (linkResult.ExpectationsAssemblyPath.FileNameWithoutExtension);
+				var linked = ResolveLinkedAssembly (linkResult.OutputAssemblyPath.FileNameWithoutExtension);
+
+				InitialChecking (linkResult, original, linked);
+
 				PerformOutputAssemblyChecks (original, linkResult.OutputAssemblyPath.Parent);
 				PerformOutputSymbolChecks (original, linkResult.OutputAssemblyPath.Parent);
 
-				var linked = ResolveLinkedAssembly (linkResult.OutputAssemblyPath.FileNameWithoutExtension);
-
 				CreateAssemblyChecker (original, linked).Verify ();
 
 				VerifyLinkingOfOtherAssemblies (original);
 
-#if !NETCOREAPP
-				// the PE Verifier does not know how to resolve .NET Core assemblies.
-				_peVerifier.Check (linkResult, original);
-#endif
-
 				AdditionalChecking (linkResult, original, linked);
 			}
 			finally
@@ -170,6 +167,14 @@ namespace Mono.Linker.Tests.TestCasesRunner {
 		{
 		}
 
+		protected virtual void InitialChecking (LinkedTestCaseResult linkResult, AssemblyDefinition original, AssemblyDefinition linked)
+		{
+#if !NETCOREAPP
+			// the PE Verifier does not know how to resolve .NET Core assemblies.
+			_peVerifier.Check (linkResult, original);
+#endif
+		}
+
 		void VerifyLinkingOfOtherAssemblies (AssemblyDefinition original)
 		{
 			var checks = BuildOtherAssemblyCheckTable (original);