From acd72ce63588a6cb5005787938282e56fd207d3a Mon Sep 17 00:00:00 2001 From: Mateo Torres-Ruiz Date: Fri, 30 Jul 2021 16:18:00 -0700 Subject: Share DiagnosticStrings add mechanism to generate a DiagnosticDescriptor given a DiagnosticId (#2170) * Add DiagnosticId enum Add GetDiagnosticDescriptor * Check that the diagnostic id is in the range of the supported linker warnings * Lint * Share DiagnosticString * Noisy whitespace * Warnings go up to 6000 inclusive * PR feedback * Get diagnostic string Update test * Lint * PR feedback --- .../VirtualMethodHierarchyDataflowAnnotationValidation.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'test/Mono.Linker.Tests.Cases/DataFlow') diff --git a/test/Mono.Linker.Tests.Cases/DataFlow/VirtualMethodHierarchyDataflowAnnotationValidation.cs b/test/Mono.Linker.Tests.Cases/DataFlow/VirtualMethodHierarchyDataflowAnnotationValidation.cs index 25107c005..4e59e09b4 100644 --- a/test/Mono.Linker.Tests.Cases/DataFlow/VirtualMethodHierarchyDataflowAnnotationValidation.cs +++ b/test/Mono.Linker.Tests.Cases/DataFlow/VirtualMethodHierarchyDataflowAnnotationValidation.cs @@ -271,9 +271,13 @@ namespace Mono.Linker.Tests.Cases.DataFlow // === RequiresUnreferencedCode === - [ExpectedWarning ("IL2046", "DerivedClass.RequiresUnreferencedCodeBaseWithDerivedWithout()", "BaseClass.RequiresUnreferencedCodeBaseWithDerivedWithout()")] + [ExpectedWarning ("IL2046", "DerivedClass.RequiresUnreferencedCodeBaseWithDerivedWithout()", + "BaseClass.RequiresUnreferencedCodeBaseWithDerivedWithout()", + "'RequiresUnreferencedCodeAttribute' annotations must match across all interface implementations or overrides")] public override void RequiresUnreferencedCodeBaseWithDerivedWithout () { } - [ExpectedWarning ("IL2046", "DerivedClass.RequiresUnreferencedCodeBaseWithoutDerivedWith_()", "BaseClass.RequiresUnreferencedCodeBaseWithoutDerivedWith_()")] + [ExpectedWarning ("IL2046", "DerivedClass.RequiresUnreferencedCodeBaseWithoutDerivedWith_()", + "BaseClass.RequiresUnreferencedCodeBaseWithoutDerivedWith_()", + "'RequiresUnreferencedCodeAttribute' annotations must match across all interface implementations or overrides")] [RequiresUnreferencedCode ("")] public override void RequiresUnreferencedCodeBaseWithoutDerivedWith_ () { } [LogDoesNotContain ("DerivedClass.RequiresUnreferencedCodeBaseWithDerivedWith_")] -- cgit v1.2.3