From 54456b4ad366d20bb117c5bea0a8744cc3804047 Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Fri, 17 May 2019 13:03:42 -0700 Subject: Sweep attributes on GenericParameters and InterfaceImplementations (#571) * Update dependencies from https://github.com/dotnet/arcade build 20190514.13 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19264.13 * Update dependencies from https://github.com/dotnet/arcade build 20190516.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.2 * Sweep attributes on GenericParameters and InterfaceImplementations This fixes test failures that show up due to NullableAttribute with recent versions of .NET Core (https://github.com/mono/linker/pull/570) * Increase line count limit for reduced tracing test * Add test for sweeping attributes on GenericParameters --- test/Mono.Linker.Tests/TestCases/IndividualTests.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'test/Mono.Linker.Tests') diff --git a/test/Mono.Linker.Tests/TestCases/IndividualTests.cs b/test/Mono.Linker.Tests/TestCases/IndividualTests.cs index c8c1a8833..cdc269de6 100644 --- a/test/Mono.Linker.Tests/TestCases/IndividualTests.cs +++ b/test/Mono.Linker.Tests/TestCases/IndividualTests.cs @@ -73,8 +73,9 @@ namespace Mono.Linker.Tests.TestCases var lineCount = outputPath.ReadAllLines ().Length; // When reduced tracing is not enabled there are around 16k of lines in the output file. - // With reduced tracing there should be less than 65, but to be safe, we'll check for less than 100. - const int expectedMaxLines = 100; + // With reduced tracing there should be less than 65, but to be safe, we'll check for less than 200. + // Reduced tracing on System.Private.CoreLib.dll produces about 130 lines just for NullableAttribute usages. + const int expectedMaxLines = 200; Assert.That (lineCount, Is.LessThan (expectedMaxLines), $"There were `{lineCount}` lines in the dump file. This is more than expected max of {expectedMaxLines} and likely indicates reduced tracing was not enabled. Dump file can be found at: {outputPath}"); } -- cgit v1.2.3