1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
|
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
using System;
using System.Diagnostics.CodeAnalysis;
using System.Threading.Tasks;
using ILLink.CodeFix;
using ILLink.Shared;
using Microsoft.CodeAnalysis.CodeFixes;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Testing;
using Microsoft.CodeAnalysis.Text;
using Xunit;
using VerifyCSUSMwithRAF = ILLink.RoslynAnalyzer.Tests.CSharpCodeFixVerifier<
ILLink.RoslynAnalyzer.RequiresAssemblyFilesAnalyzer,
ILLink.CodeFix.UnconditionalSuppressMessageCodeFixProvider>;
using VerifyCSUSMwithRUC = ILLink.RoslynAnalyzer.Tests.CSharpCodeFixVerifier<
ILLink.RoslynAnalyzer.RequiresUnreferencedCodeAnalyzer,
ILLink.CodeFix.UnconditionalSuppressMessageCodeFixProvider>;
namespace ILLink.RoslynAnalyzer.Tests
{
public class UnconditionalSuppressMessageCodeFixTests
{
static Task VerifyUnconditionalSuppressMessageCodeFixWithRUC (
string source,
string fixedSource,
DiagnosticResult[] baselineExpected,
DiagnosticResult[] fixedExpected)
{
var test = new VerifyCSUSMwithRUC.Test {
TestCode = source,
FixedCode = fixedSource,
ReferenceAssemblies = TestCaseUtils.Net6PreviewAssemblies
};
test.ExpectedDiagnostics.AddRange (baselineExpected);
test.TestState.AnalyzerConfigFiles.Add (
("/.editorconfig", SourceText.From (@$"
is_global = true
build_property.{MSBuildPropertyOptionNames.EnableTrimAnalyzer} = true")));
test.FixedState.ExpectedDiagnostics.AddRange (fixedExpected);
return test.RunAsync ();
}
static Task VerifyUnconditionalSuppressMessageCodeFixWithRAF (
string source,
string fixedSource,
DiagnosticResult[] baselineExpected,
DiagnosticResult[] fixedExpected)
{
var test = new VerifyCSUSMwithRAF.Test {
TestCode = source,
FixedCode = fixedSource,
ReferenceAssemblies = TestCaseUtils.Net6PreviewAssemblies
};
test.ExpectedDiagnostics.AddRange (baselineExpected);
test.TestState.AnalyzerConfigFiles.Add (
("/.editorconfig", SourceText.From (@$"
is_global = true
build_property.{MSBuildPropertyOptionNames.EnableSingleFileAnalyzer} = true")));
test.FixedState.ExpectedDiagnostics.AddRange (fixedExpected);
return test.RunAsync ();
}
[Fact]
public Task SuppressRequiresUnreferencedCodeFixer ()
{
var test = @"
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCode(""message"")]
public int M1() => 0;
int M2() => M1();
}";
var fixtest = @"
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCode(""message"")]
public int M1() => 0;
[UnconditionalSuppressMessage(""Trimming"", ""IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code"", Justification = ""<Pending>"")]
int M2() => M1();
}";
return VerifyUnconditionalSuppressMessageCodeFixWithRUC (
test,
fixtest,
baselineExpected: new[] {
// /0/Test0.cs(7,17): warning IL2026: Using member 'C.M1()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. message.
VerifyCSUSMwithRUC.Diagnostic (DiagnosticId.RequiresUnreferencedCode).WithSpan (7, 17, 7, 21).WithArguments ("C.M1()", " message.", ""),
},
fixedExpected: Array.Empty<DiagnosticResult> ());
}
[Fact]
public Task SuppressRequiresAssemblyFilesFixer ()
{
var test = @"
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresAssemblyFiles(""message"")]
public int M1() => 0;
int M2() => M1();
}";
var fixtest = @"
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresAssemblyFiles(""message"")]
public int M1() => 0;
[UnconditionalSuppressMessage(""SingleFile"", ""IL3002:Avoid calling members marked with 'RequiresAssemblyFilesAttribute' when publishing as a single-file"", Justification = ""<Pending>"")]
int M2() => M1();
}";
return VerifyUnconditionalSuppressMessageCodeFixWithRAF (
test,
fixtest,
baselineExpected: new[] {
// /0/Test0.cs(7,17): warning IL2026: Using member 'C.M1()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. message.
VerifyCSUSMwithRAF.Diagnostic (DiagnosticId.RequiresAssemblyFiles).WithSpan (7, 17, 7, 21).WithArguments ("C.M1()", " message.", "")
},
fixedExpected: Array.Empty<DiagnosticResult> ());
}
[Fact]
public Task FixInSingleFileSpecialCases ()
{
var test = @"
using System.Reflection;
using System.Diagnostics.CodeAnalysis;
public class C
{
public static Assembly assembly = Assembly.LoadFrom(""/some/path/not/in/bundle"");
public string M1() => assembly.Location;
public void M2() {
_ = assembly.GetFiles();
}
}
";
var fixtest = @"
using System.Reflection;
using System.Diagnostics.CodeAnalysis;
public class C
{
public static Assembly assembly = Assembly.LoadFrom(""/some/path/not/in/bundle"");
[UnconditionalSuppressMessage(""SingleFile"", ""IL3000:Avoid accessing Assembly file path when publishing as a single file"", Justification = ""<Pending>"")]
public string M1() => assembly.Location;
[UnconditionalSuppressMessage(""SingleFile"", ""IL3001:Avoid accessing Assembly file path when publishing as a single file"", Justification = ""<Pending>"")]
public void M2() {
_ = assembly.GetFiles();
}
}
";
return VerifyUnconditionalSuppressMessageCodeFixWithRAF (
test,
fixtest,
baselineExpected: new[] {
// /0/Test0.cs(7,27): warning IL3000: 'System.Reflection.Assembly.Location' always returns an empty string for assemblies embedded in a single-file app. If the path to the app directory is needed, consider calling 'System.AppContext.BaseDirectory'.
VerifyCSUSMwithRAF.Diagnostic(DiagnosticId.AvoidAssemblyLocationInSingleFile).WithSpan (7, 27, 7, 44).WithArguments ("System.Reflection.Assembly.Location", "", ""),
// /0/Test0.cs(9,13): warning IL3001: 'System.Reflection.Assembly.GetFiles()' will throw for assemblies embedded in a single-file app
VerifyCSUSMwithRAF.Diagnostic(DiagnosticId.AvoidAssemblyGetFilesInSingleFile).WithSpan (9, 13, 9, 32).WithArguments("System.Reflection.Assembly.GetFiles()", "", ""),
},
fixedExpected: Array.Empty<DiagnosticResult> ());
}
[Fact]
public Task FixInPropertyDecl ()
{
var src = @"
using System;
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCodeAttribute(""message"")]
public int M1() => 0;
int M2 => M1();
}";
var fix = @"
using System;
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCodeAttribute(""message"")]
public int M1() => 0;
[UnconditionalSuppressMessage(""Trimming"", ""IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code"", Justification = ""<Pending>"")]
int M2 => M1();
}";
return VerifyUnconditionalSuppressMessageCodeFixWithRUC (
src,
fix,
baselineExpected: new[] {
// /0/Test0.cs(10,15): warning IL2026: Using member 'C.M1()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. message.
VerifyCSUSMwithRUC.Diagnostic (DiagnosticId.RequiresUnreferencedCode).WithSpan(10, 15, 10, 19).WithArguments("C.M1()", " message.", "")
},
fixedExpected: Array.Empty<DiagnosticResult> ());
}
[Fact]
public Task FixInField ()
{
const string src = @"
using System;
using System.Diagnostics.CodeAnalysis;
class C
{
public static Lazy<C> _default = new Lazy<C>(InitC);
public static C Default => _default.Value;
[RequiresAssemblyFiles]
public static C InitC() {
C cObject = new C();
return cObject;
}
}";
var fixtest = @"
using System;
using System.Diagnostics.CodeAnalysis;
class C
{
[UnconditionalSuppressMessage(""SingleFile"", ""IL3002:Avoid calling members marked with 'RequiresAssemblyFilesAttribute' when publishing as a single-file"", Justification = ""<Pending>"")]
public static Lazy<C> _default = new Lazy<C>(InitC);
public static C Default => _default.Value;
[RequiresAssemblyFiles]
public static C InitC() {
C cObject = new C();
return cObject;
}
}";
return VerifyUnconditionalSuppressMessageCodeFixWithRAF (
src,
fixtest,
baselineExpected: new[] {
// /0/Test0.cs(6,50): warning IL3002: Using member 'C.InitC()' which has 'RequiresAssemblyFilesAttribute' can break functionality when embedded in a single-file app.
VerifyCSUSMwithRAF.Diagnostic (DiagnosticId.RequiresAssemblyFiles).WithSpan (6, 50, 6, 55).WithArguments ("C.InitC()", "", ""),
},
fixedExpected: Array.Empty<DiagnosticResult> ());
}
[Fact]
public Task FixInLocalFunc ()
{
var src = @"
using System;
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCodeAttribute(""message"")]
public int M1() => 0;
Action M2()
{
void Wrapper () => M1();
return Wrapper;
}
}";
var fix = @"
using System;
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCodeAttribute(""message"")]
public int M1() => 0;
Action M2()
{
[global::System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute(""Trimming"", ""IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code"", Justification = ""<Pending>"")] void Wrapper () => M1();
return Wrapper;
}
}";
// Roslyn currently doesn't simplify the attribute name properly, see https://github.com/dotnet/roslyn/issues/52039
return VerifyUnconditionalSuppressMessageCodeFixWithRUC (
src,
fix,
baselineExpected: new[] {
// /0/Test0.cs(12,28): warning IL2026: Using member 'C.M1()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. message.
VerifyCSUSMwithRUC.Diagnostic (DiagnosticId.RequiresUnreferencedCode).WithSpan(12, 28, 12, 32).WithArguments("C.M1()", " message.", "")
},
fixedExpected: Array.Empty<DiagnosticResult> ());
}
[Fact]
public Task FixInCtor ()
{
var src = @"
using System;
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCodeAttribute(""message"")]
public int M1() => 0;
public C () => M1();
}";
var fix = @"
using System;
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCodeAttribute(""message"")]
public int M1() => 0;
[UnconditionalSuppressMessage(""Trimming"", ""IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code"", Justification = ""<Pending>"")]
public C () => M1();
}";
return VerifyUnconditionalSuppressMessageCodeFixWithRUC (
src,
fix,
baselineExpected: new[] {
// /0/Test0.cs(10,15): warning IL2026: Using member 'C.M1()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. message.
VerifyCSUSMwithRUC.Diagnostic (DiagnosticId.RequiresUnreferencedCode).WithSpan(10, 20, 10, 24).WithArguments("C.M1()", " message.", "")
},
fixedExpected: Array.Empty<DiagnosticResult> ());
}
[Fact]
public Task FixInEvent ()
{
var src = @"
using System;
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCodeAttribute(""message"")]
public int M1() => 0;
public event EventHandler E1
{
add
{
var a = M1();
}
remove { }
}
}";
var fix = @"
using System;
using System.Diagnostics.CodeAnalysis;
public class C
{
[RequiresUnreferencedCodeAttribute(""message"")]
public int M1() => 0;
[UnconditionalSuppressMessage(""Trimming"", ""IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code"", Justification = ""<Pending>"")]
public event EventHandler E1
{
add
{
var a = M1();
}
remove { }
}
}";
return VerifyUnconditionalSuppressMessageCodeFixWithRUC (
src,
fix,
baselineExpected: new[] {
// /0/Test0.cs(14,21): warning IL2026: Using member 'C.M1()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. message.
VerifyCSUSMwithRUC.Diagnostic (DiagnosticId.RequiresUnreferencedCode).WithSpan(14, 21, 14, 25).WithArguments("C.M1()", " message.", "")
},
fixedExpected: Array.Empty<DiagnosticResult> ());
}
}
}
|