1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
|
// Copyright (c) .NET Foundation and contributors. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
using System;
using System.Diagnostics.CodeAnalysis;
using Mono.Linker.Tests.Cases.Expectations.Assertions;
using Mono.Linker.Tests.Cases.Expectations.Helpers;
using Mono.Linker.Tests.Cases.Expectations.Metadata;
namespace Mono.Linker.Tests.Cases.DataFlow
{
[SkipKeptItemsValidation]
[ExpectedNoWarnings]
class MethodByRefParameterDataFlow
{
public static void Main ()
{
Type typeWithMethods = _fieldWithMethods;
TestAssignStaticToAnnotatedRefParameter (ref typeWithMethods);
TestAssignParameterToAnnotatedRefParameter (ref typeWithMethods, typeof (TestType));
TestReadFromRefParameter ();
TestReadFromOutParameter_PassedTwice ();
TestReadFromRefParameter_MismatchOnOutput ();
TestReadFromRefParameter_MismatchOnOutput_PassedTwice ();
TestReadFromRefParameter_MismatchOnInput ();
TestReadFromRefParameter_MismatchOnInput_PassedTwice ();
Type nullType1 = null;
TestPassingRefParameter (ref nullType1);
Type nullType2 = null;
TestPassingRefParameter_Mismatch (ref nullType2);
Type nullType3 = null;
TestAssigningToRefParameter (nullType3, ref nullType3);
Type nullType4 = null;
TestAssigningToRefParameter_Mismatch (nullType4, ref nullType4);
}
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)]
static Type _fieldWithMethods = null;
[ExpectedWarning ("IL2026", "Message for --TestType.Requires--")]
// https://github.com/dotnet/linker/issues/2158
// The type.GetMethods call generates a warning because we're not able to correctly track the value of the "this".
// (there's a ldind.ref insruction here which we currently don't handle and the "this" becomes unknown)
[ExpectedWarning ("IL2065")]
static void TestAssignStaticToAnnotatedRefParameter ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] ref Type type)
{
type = typeof (TestTypeWithRequires);
type.GetMethods (); // Should not warn
}
// The warning message is REALLY confusing (basically wrong) since it talks about "calling the method with wrong argument"
// which is definitely not the case here.
[ExpectedWarning ("IL2067", "typeWithFields")]
// https://github.com/dotnet/linker/issues/2158
// The type.GetMethods call generates a warning because we're not able to correctly track the value of the "this".
// (there's a ldind.ref insruction here which we currently don't handle and the "this" becomes unknown)
[ExpectedWarning ("IL2065")]
static void TestAssignParameterToAnnotatedRefParameter (
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] ref Type type,
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicFields)] Type typeWithFields)
{
type = typeWithFields; // Should warn
type.GetMethods (); // Should not warn
}
class TestTypeWithRequires
{
[RequiresUnreferencedCode ("Message for --TestType.Requires--")]
public static void Requires () { }
}
static void TestReadFromRefParameter ()
{
Type typeWithMethods = null;
TryGetAnnotatedValue (ref typeWithMethods);
typeWithMethods.RequiresPublicMethods ();
}
static void TestReadFromOutParameter_PassedTwice ()
{
Type typeWithMethods = null;
TryGetAnnotatedValueFromValue (typeWithMethods, ref typeWithMethods);
typeWithMethods.RequiresPublicMethods ();
}
// https://github.com/dotnet/linker/issues/2632
// This test should generate a warning since there's mismatch on annotations
// [ExpectedWarning ("IL2062", nameof (DataFlowTypeExtensions.RequiresPublicFields))]
static void TestReadFromRefParameter_MismatchOnOutput ()
{
Type typeWithMethods = null;
TryGetAnnotatedValue (ref typeWithMethods);
typeWithMethods.RequiresPublicFields ();
}
// https://github.com/dotnet/linker/issues/2632
// This test should generate a warning since there's mismatch on annotations
// [ExpectedWarning ("IL2062", nameof (DataFlowTypeExtensions.RequiresPublicFields))]
static void TestReadFromRefParameter_MismatchOnOutput_PassedTwice ()
{
Type typeWithMethods = null;
TryGetAnnotatedValueFromValue (typeWithMethods, ref typeWithMethods);
typeWithMethods.RequiresPublicFields ();
}
[ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValue))]
// https://github.com/dotnet/linker/issues/2632
// This second warning should not be generated, the value of typeWithMethods should have PublicMethods
// after the call with out parameter.
[ExpectedWarning ("IL2072", nameof (DataFlowTypeExtensions.RequiresPublicMethods))]
static void TestReadFromRefParameter_MismatchOnInput ()
{
Type typeWithMethods = GetTypeWithFields ();
TryGetAnnotatedValue (ref typeWithMethods);
typeWithMethods.RequiresPublicMethods ();
}
[ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValueFromValue))]
[ExpectedWarning ("IL2072", nameof (TryGetAnnotatedValueFromValue))]
// https://github.com/dotnet/linker/issues/2632
// This third warning should not be generated, the value of typeWithMethods should have PublicMethods
// after the call with ref parameter.
[ExpectedWarning ("IL2072", nameof (DataFlowTypeExtensions.RequiresPublicMethods))]
static void TestReadFromRefParameter_MismatchOnInput_PassedTwice ()
{
Type typeWithMethods = GetTypeWithFields ();
TryGetAnnotatedValueFromValue (typeWithMethods, ref typeWithMethods);
typeWithMethods.RequiresPublicMethods ();
}
static void TestPassingRefParameter ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] ref Type typeWithMethods)
{
TryGetAnnotatedValue (ref typeWithMethods);
}
[ExpectedWarning ("IL2067", "typeWithMethods", nameof (TryGetAnnotatedValue))]
static void TestPassingRefParameter_Mismatch ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicFields)] ref Type typeWithMethods)
{
TryGetAnnotatedValue (ref typeWithMethods);
}
static void TestAssigningToRefParameter (
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] Type inputTypeWithMethods,
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] ref Type outputTypeWithMethods)
{
outputTypeWithMethods = inputTypeWithMethods;
}
[ExpectedWarning ("IL2067", "inputTypeWithFields", "outputTypeWithMethods")]
static void TestAssigningToRefParameter_Mismatch (
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicFields)] Type inputTypeWithFields,
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] ref Type outputTypeWithMethods)
{
outputTypeWithMethods = inputTypeWithFields;
}
static bool TryGetAnnotatedValue ([DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] ref Type typeWithMethods)
{
typeWithMethods = null;
return false;
}
static bool TryGetAnnotatedValueFromValue (
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] Type inValue,
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] ref Type typeWithMethods)
{
typeWithMethods = inValue;
return false;
}
[return: DynamicallyAccessedMembersAttribute (DynamicallyAccessedMemberTypes.PublicFields)]
static Type GetTypeWithFields () => null;
class TestType
{
}
}
}
|
