diff options
author | Lluis Sanchez <llsan@microsoft.com> | 2021-05-28 13:28:18 +0300 |
---|---|---|
committer | Lluis Sanchez <llsan@microsoft.com> | 2021-05-28 13:28:18 +0300 |
commit | 0fa6fcf837c302f0c581d377d324bc1dd1f78ff3 (patch) | |
tree | 5b70f15a448bcafa9b89e50aa66a7bbf604fcc5c | |
parent | 3d58ee571727919ccfd29f7fe382634dc9dc4ef6 (diff) |
Minor perf optimization
Revert some conditions in AddinFolderVisitor so that the fastest
condition is evaluated first
-rw-r--r-- | Mono.Addins/Mono.Addins.Database/AddinFolderVisitor.cs | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/Mono.Addins/Mono.Addins.Database/AddinFolderVisitor.cs b/Mono.Addins/Mono.Addins.Database/AddinFolderVisitor.cs index 3ba62f0..05fb397 100644 --- a/Mono.Addins/Mono.Addins.Database/AddinFolderVisitor.cs +++ b/Mono.Addins/Mono.Addins.Database/AddinFolderVisitor.cs @@ -75,7 +75,7 @@ namespace Mono.Addins.Database List<AddinsEntry> addinsFileEntries = new List<AddinsEntry>(); foreach (string file in files) { - if (Path.GetExtension (file).EndsWith (".addins", StringComparison.Ordinal)) + if (file.EndsWith (".addins", StringComparison.Ordinal)) addinsFileEntries.AddRange (ParseAddinsFile (monitor, file, domain)); } @@ -84,17 +84,15 @@ namespace Mono.Addins.Database // included in .addin files won't be scanned twice). foreach (string file in files) { - if (!ScanContext.IgnorePath (file) && (file.EndsWith (".addin.xml", StringComparison.Ordinal) || file.EndsWith (".addin", StringComparison.Ordinal))) + if ((file.EndsWith(".addin.xml", StringComparison.Ordinal) || file.EndsWith(".addin", StringComparison.Ordinal)) && !ScanContext.IgnorePath (file)) OnVisitAddinManifestFile (monitor, file); } // Now scan assemblies. They can also add files to the ignore list. foreach (string file in files) { - if (!ScanContext.IgnorePath (file)) { - string ext = Path.GetExtension(file).ToLower(); - if (ext == ".dll" || ext == ".exe") - OnVisitAssemblyFile(monitor, file); + if ((file.EndsWith(".dll", StringComparison.OrdinalIgnoreCase) || file.EndsWith(".exe", StringComparison.OrdinalIgnoreCase)) && !ScanContext.IgnorePath(file)) { + OnVisitAssemblyFile(monitor, file); } } |