2010-06-04 Sebastien Pouliot <sebastien@ximian.com>

	* AvoidConcatenatingCharsRule.cs:
	* AvoidRepetitiveCallsToPropertiesRule.cs:
	* PreferCharOverloadRule.cs:
	* ReviewLinqMethodRule.cs:
 		Apply AvoidUnnecessarySpecializationRule


svn path=/trunk/mono-tools/; revision=158512

5 files changed, 13 insertions, 5 deletions

diff --git a/gendarme/rules/Gendarme.Rules.Performance/AvoidConcatenatingCharsRule.cs b/gendarme/rules/Gendarme.Rules.Performance/AvoidConcatenatingCharsRule.cs
index f62e3d5b..151556d7 100644
--- a/gendarme/rules/Gendarme.Rules.Performance/AvoidConcatenatingCharsRule.cs
+++ b/gendarme/rules/Gendarme.Rules.Performance/AvoidConcatenatingCharsRule.cs
@@ -74,7 +74,7 @@ namespace Gendarme.Rules.Performance {
 	[EngineDependency (typeof (OpCodeEngine))]
 	public class AvoidConcatenatingCharsRule : Rule, IMethodRule {
 
-		static bool IsStringConcat (MemberReference member)
+		static bool IsStringConcat (IMemberReference member)
 		{
 			if (member == null || (member.Name != "Concat"))
 				return false;
@@ -132,7 +132,7 @@ namespace Gendarme.Rules.Performance {
 			}
 		}
 
-		private void CheckParameters (MethodReference concat, MethodDefinition caller, Instruction ins)
+		private void CheckParameters (IMethodSignature concat, MethodDefinition caller, Instruction ins)
 		{
 			// check for boxed (likely char, but could be other types too) on any parameter
 			for (int i = 0; i < concat.Parameters.Count; i++) {
diff --git a/gendarme/rules/Gendarme.Rules.Performance/AvoidRepetitiveCallsToPropertiesRule.cs b/gendarme/rules/Gendarme.Rules.Performance/AvoidRepetitiveCallsToPropertiesRule.cs
index f30ef644..15713290 100644
--- a/gendarme/rules/Gendarme.Rules.Performance/AvoidRepetitiveCallsToPropertiesRule.cs
+++ b/gendarme/rules/Gendarme.Rules.Performance/AvoidRepetitiveCallsToPropertiesRule.cs
@@ -190,7 +190,7 @@ namespace Gendarme.Rules.Performance {
 			return ReportResults (method);
 		}
 
-		private RuleResult ReportResults (MethodDefinition method)
+		private RuleResult ReportResults (IMetadataTokenProvider method)
 		{
 			foreach (KeyValuePair<string, KeyValuePair<MethodDefinition, int>> kvp in calls) {
 				// look which getter we're calling more than once
diff --git a/gendarme/rules/Gendarme.Rules.Performance/ChangeLog b/gendarme/rules/Gendarme.Rules.Performance/ChangeLog
index f9b7c0b9..f8087650 100644
--- a/gendarme/rules/Gendarme.Rules.Performance/ChangeLog
+++ b/gendarme/rules/Gendarme.Rules.Performance/ChangeLog
@@ -1,3 +1,11 @@
+2010-06-04  Sebastien Pouliot  <sebastien@ximian.com>
+
+	* AvoidConcatenatingCharsRule.cs:
+	* AvoidRepetitiveCallsToPropertiesRule.cs:
+	* PreferCharOverloadRule.cs:
+	* ReviewLinqMethodRule.cs:
+ 		Apply AvoidUnnecessarySpecializationRule
+
 2010-05-24  Sebastien Pouliot  <sebastien@ximian.com>
 
 	* AvoidUnusedParametersRule.cs: Documented (MSDN) as a Performance
diff --git a/gendarme/rules/Gendarme.Rules.Performance/PreferCharOverloadRule.cs b/gendarme/rules/Gendarme.Rules.Performance/PreferCharOverloadRule.cs
index ae1c590a..f9defaba 100644
--- a/gendarme/rules/Gendarme.Rules.Performance/PreferCharOverloadRule.cs
+++ b/gendarme/rules/Gendarme.Rules.Performance/PreferCharOverloadRule.cs
@@ -144,7 +144,7 @@ namespace Gendarme.Rules.Performance {
 			Runner.Report (method, ins, Severity.Medium, Confidence.High, msg);
 		}
 
-		static bool CheckFirstParameterIsString (MethodReference method)
+		static bool CheckFirstParameterIsString (IMethodSignature method)
 		{
 			return (method.HasParameters && (method.Parameters [0].ParameterType.FullName == "System.String"));
 		}
diff --git a/gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs b/gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs
index bedca9dd..3e666533 100644
--- a/gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs
+++ b/gendarme/rules/Gendarme.Rules.Performance/ReviewLinqMethodRule.cs
@@ -117,7 +117,7 @@ namespace Gendarme.Rules.Performance {
 			return td != null && td.BaseType != null && HasMethod (td.BaseType, method);
 		}
 		
-		private void CheckForCountProperty (TypeDefinition type, MethodDefinition method, Instruction ins)
+		private void CheckForCountProperty (TypeReference type, MethodDefinition method, Instruction ins)
 		{
 			if (HasMethod (type, CountProperty)) {
 				string message = "Use the Count property instead of the Count () method.";