diff options
| author | Jesse Jones <jesjones@mono-cvs.ximian.com> | 2008-12-31 02:49:58 +0300 |
|---|---|---|
| committer | Jesse Jones <jesjones@mono-cvs.ximian.com> | 2008-12-31 02:49:58 +0300 |
| commit | 26e958b47a787bdb9c7d06cc7218311306fc81ab (patch) | |
| tree | af2612b8d69836641f8a2554e05ddf1835d773f3 | |
| parent | 6a683c0a372962d02d17533ec967b7a9ea37e019 (diff) | |
StackEntryAnalysis and Bitmask GetHashCode methods now use
unchecked math.
svn path=/trunk/mono-tools/; revision=122278
4 files changed, 20 insertions, 5 deletions
diff --git a/gendarme/framework/Gendarme.Framework.Helpers/ChangeLog b/gendarme/framework/Gendarme.Framework.Helpers/ChangeLog index ebb65813..3bb730fb 100644 --- a/gendarme/framework/Gendarme.Framework.Helpers/ChangeLog +++ b/gendarme/framework/Gendarme.Framework.Helpers/ChangeLog @@ -1,3 +1,8 @@ +2008-12-30 Jesse Jones <jesjones@mindspring.com> + + * StackEntryAnalysis.cs: Changed GetHashCode to use unchecked + math. + 2008-12-01 Sebastien Pouliot <sebastien@ximian.com> * MethodSignature.cs: Use HasParameters diff --git a/gendarme/framework/Gendarme.Framework.Helpers/StackEntryAnalysis.cs b/gendarme/framework/Gendarme.Framework.Helpers/StackEntryAnalysis.cs index d34eccb5..2b8cad83 100644 --- a/gendarme/framework/Gendarme.Framework.Helpers/StackEntryAnalysis.cs +++ b/gendarme/framework/Gendarme.Framework.Helpers/StackEntryAnalysis.cs @@ -205,11 +205,16 @@ namespace Gendarme.Framework.Helpers { public override int GetHashCode () { - int hc = Instruction.GetHashCode (); - if (LeaveStack != null) { - foreach (Instruction ins in LeaveStack) - hc ^= ins.GetHashCode (); + int hc = 0; + + unchecked { + hc ^= Instruction.GetHashCode (); + if (LeaveStack != null) { + foreach (Instruction ins in LeaveStack) + hc ^= ins.GetHashCode (); + } } + return hc; } diff --git a/gendarme/framework/Gendarme.Framework/Bitmask.cs b/gendarme/framework/Gendarme.Framework/Bitmask.cs index 5c0211ab..099198d2 100644 --- a/gendarme/framework/Gendarme.Framework/Bitmask.cs +++ b/gendarme/framework/Gendarme.Framework/Bitmask.cs @@ -169,7 +169,7 @@ namespace Gendarme.Framework { public override int GetHashCode () { - return (int) (mask ^ (mask >> 32)); + return unchecked ((int) (mask ^ (mask >> 32))); } public override string ToString () diff --git a/gendarme/framework/Gendarme.Framework/ChangeLog b/gendarme/framework/Gendarme.Framework/ChangeLog index 84dd93d4..6d02c7f4 100644 --- a/gendarme/framework/Gendarme.Framework/ChangeLog +++ b/gendarme/framework/Gendarme.Framework/ChangeLog @@ -1,3 +1,8 @@ +2008-12-30 Jesse Jones <jesjones@mindspring.com> + + * Bitmask.cs: Changed GetHashCode to use unchecked + math. + 2008-12-28 Sebastien Pouliot <sebastien@ximian.com> * Symbols.cs: Allow reports to include the source information when |