diff options
| author | Sebastien Pouliot <sebastien@ximian.com> | 2008-02-12 21:29:04 +0300 |
|---|---|---|
| committer | Sebastien Pouliot <sebastien@ximian.com> | 2008-02-12 21:29:04 +0300 |
| commit | b0525f1ec74bf14568b40494d7e99092b3c7b739 (patch) | |
| tree | 95c38bf7cd20f457c505d47c7dc7e8146419a819 | |
| parent | b5d0da83bd3cb9fa726b0c57c3da8b200db8ff11 (diff) | |
2008-02-12 Sebastien Pouliot <sebastien@ximian.com>
* Gendarme.Rules.Concurrency.xml.in: Fix copy-paste mistake for
NonConstantStaticFieldsShouldNotBeVisibleRule.
[Backport of r95541]
svn path=/branches/mono-1-9/mono-tools/; revision=95542
| -rw-r--r-- | gendarme/rules/Gendarme.Rules.Concurrency/ChangeLog | 6 | ||||
| -rw-r--r-- | gendarme/rules/Gendarme.Rules.Concurrency/Gendarme.Rules.Concurrency.xml.in | 4 |
2 files changed, 8 insertions, 2 deletions
diff --git a/gendarme/rules/Gendarme.Rules.Concurrency/ChangeLog b/gendarme/rules/Gendarme.Rules.Concurrency/ChangeLog index daecf9c0..6d049b66 100644 --- a/gendarme/rules/Gendarme.Rules.Concurrency/ChangeLog +++ b/gendarme/rules/Gendarme.Rules.Concurrency/ChangeLog @@ -1,3 +1,9 @@ +2008-02-12 Sebastien Pouliot <sebastien@ximian.com> + + * Gendarme.Rules.Concurrency.xml.in: Fix copy-paste mistake for + NonConstantStaticFieldsShouldNotBeVisibleRule. + [Backport of r95541] + 2008-01-21 Sebastien Pouliot <sebastien@ximian.com> * NonConstantStaticFieldsShouldNotBeVisibleRule.cs: New. Rule that diff --git a/gendarme/rules/Gendarme.Rules.Concurrency/Gendarme.Rules.Concurrency.xml.in b/gendarme/rules/Gendarme.Rules.Concurrency/Gendarme.Rules.Concurrency.xml.in index c5a6c486..30693edf 100644 --- a/gendarme/rules/Gendarme.Rules.Concurrency/Gendarme.Rules.Concurrency.xml.in +++ b/gendarme/rules/Gendarme.Rules.Concurrency/Gendarme.Rules.Concurrency.xml.in @@ -3,13 +3,13 @@ Type="Gendarme.Rules.Concurrency.DoubleCheckLockingRule, Gendarme.Rules.Concurrency, Version=@GENDARME_VERSION@, Culture=neutral, PublicKeyToken=null" Uri="http://www.mono-project.com/Gendarme.Rules.Concurrency#DoubleCheckLockingRule" > <problem>Method '{0}' uses the unreliable double-check locking technique.</problem> - <solution>Remove the lock check that occurs outside of the protected region. Or see: http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html</solution> + <solution>Remove the lock check that occurs outside of the protected region. See: http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html</solution> </rule> <rule Name="NonConstantStaticFieldsShouldNotBeVisibleRule" Type="Gendarme.Rules.Concurrency.NonConstantStaticFieldsShouldNotBeVisibleRule, Gendarme.Rules.Concurrency, Version=@GENDARME_VERSION@, Culture=neutral, PublicKeyToken=null" Uri="http://www.mono-project.com/Gendarme.Rules.Concurrency#NonConstantStaticFieldsShouldNotBeVisible" > <problem>Type '{0}' has some static fields that are not constant. They may represent problems in multithreaded applications.</problem> - <solution>Remove the lock check that occurs outside of the protected region. Or see: http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html</solution> + <solution>Change the field to read-only, mark it [ThreadStatic] or make it non visible outside the assembly.</solution> </rule> <rule Name="WriteStaticFieldFromInstanceMethodRule" Type="Gendarme.Rules.Concurrency.WriteStaticFieldFromInstanceMethodRule, Gendarme.Rules.Concurrency, Version=@GENDARME_VERSION@, Culture=neutral, PublicKeyToken=null" |