diff options
| author | Yann E. MORIN <yann.morin.1998@free.fr> | 2015-05-16 20:34:17 +0300 |
|---|---|---|
| committer | Yann E. MORIN <yann.morin.1998@free.fr> | 2015-05-17 16:15:12 +0300 |
| commit | d755444be0d1faec7edbc97d03c1b5f697b65634 (patch) | |
| tree | 711d9bc20b0e1b60188b5fd66f4d41cf3b3f7b0e /mcs/Makefile | |
| parent | b42709296ab77c1222b4b95696707a0d941b42eb (diff) | |
mcs: fix installation with parallel make
In mcs/ the install of xbuild_12 and xbuild_14 will end-up installing
the same files:
${NETFRAMEWORK_DIR}/v2.0/RedistList/FrameworkList.xml
${NETFRAMEWORK_DIR}/v3.0/RedistList/FrameworkList.xml
${NETFRAMEWORK_DIR}/v3.5/RedistList/FrameworkList.xml
${NETFRAMEWORK_DIR}/v4.0/Profile/Client/RedistList/FrameworkList.xml
${NETFRAMEWORK_DIR}/v4.0/RedistList/FrameworkList.xml
${NETFRAMEWORK_DIR}/v4.5.1/RedistList/FrameworkList.xml
${NETFRAMEWORK_DIR}/v4.5/RedistList/FrameworkList.xml
This is because there is no atomicity when installing each file, and
xbuild_12 and xbuild_14 may well run in parallel, each trying to install
each of those files; but the 'install' utility will first check if the
target file exists or not, and there is a race in doing so, thus leading
to build failures like so:
http://autobuild.buildroot.org/results/c32/c3288c5d1fb94474f14a4a889e76135878d403bc/build-end.log
http://autobuild.buildroot.org/results/3cb/3cb99e5c5672cbaa2a86020129a05dfde47cdb8f/build-end.log
and many more:
http://autobuild.buildroot.net/?reason=host-mono-4.0.0
http://autobuild.buildroot.net/?reason=host-mono-4.0.1
So, ensure ordering of the install of xbuild_12 and xbuild_14 (the
ordering is completely arbitrary, either way gives the same installed
files).
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Diffstat (limited to 'mcs/Makefile')
| -rw-r--r-- | mcs/Makefile | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/mcs/Makefile b/mcs/Makefile index b94a7c82d6e..4ff236774e5 100644 --- a/mcs/Makefile +++ b/mcs/Makefile @@ -43,6 +43,10 @@ profiles-do--%: profile-do--%: $(MAKE) PROFILE=$(subst --, ,$*) +# xbuild_12 and xbuild_14 will try to install the same files, so they need +# to be ordered +profile-do--xbuild_14--install: profile-do--xbuild_12--install + # We don't want to run the tests in parallel. We want behaviour like -k. profiles-do--run-test: ret=:; $(foreach p,$(PROFILES), { $(MAKE) PROFILE=$(p) run-test || ret=false; }; ) $$ret |