Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/mono/mono.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Baulig <martin.baulig@xamarin.com>2013-12-04 23:32:48 +0400
committerMartin Baulig <martin.baulig@xamarin.com>2013-12-04 23:38:10 +0400
commitc64997288f2a7cbb804b3058dc0acdcc10fcf2e5 (patch)
tree2d2842094fa5cb5b1522ccd0a22b08a730fd11d4 /mcs/class/Microsoft.Build.Engine
parent4917c943181cece11c93b6be23781d13e7d6853f (diff)
[xbuild]: Fix the tests.
'TestMessageLogger.Count' should not be used in tests to check for the number of logged messages because it would also includes diagnostic messages. Extra diagnostic messages should not be considered an error condition; in fact, we have too few diagnostic messages, not too many. Use 'TestMessageLogger.NormalMessageCount' and 'TestMessageLogger.WarningMessageCount' instead.
Diffstat (limited to 'mcs/class/Microsoft.Build.Engine')
-rw-r--r--mcs/class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine/TargetTest.cs3
1 files changed, 2 insertions, 1 deletions
diff --git a/mcs/class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine/TargetTest.cs b/mcs/class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine/TargetTest.cs
index faa959fae4e..738cd2a2587 100644
--- a/mcs/class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine/TargetTest.cs
+++ b/mcs/class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine/TargetTest.cs
@@ -416,6 +416,7 @@ namespace MonoTests.Microsoft.Build.BuildEngine {
for (int i = 0; i < messages.Length; i++)
logger.CheckLoggedMessageHead (messages [i], i.ToString ());
Assert.AreEqual(0, logger.NormalMessageCount, "Extra messages found");
+ Assert.AreEqual(0, logger.WarningMessageCount, "Extra warningmessages found");
Assert.AreEqual(expectedTargetCount, logger.TargetStarted, "TargetStarted count");
Assert.AreEqual(expectedTargetCount, logger.TargetFinished, "TargetFinished count");
@@ -968,7 +969,7 @@ namespace MonoTests.Microsoft.Build.BuildEngine {
{
engine = new Engine (Consts.BinPath);
project = engine.CreateNewProject ();
- project.Load (Path.Combine ("Test", "resources", "TestReturns.csproj"));
+ project.Load (Path.Combine ("Test", Path.Combine ("resources", "TestReturns.csproj")));
var logger = new TestMessageLogger ();
engine.RegisterLogger (logger);