diff options
| author | Jo Shields <jo.shields@xamarin.com> | 2014-12-15 15:07:29 +0300 |
|---|---|---|
| committer | Jo Shields <jo.shields@xamarin.com> | 2014-12-15 15:07:29 +0300 |
| commit | 7b58afa1c8f37c0c82e8d95e8b274834b2fecbbc (patch) | |
| tree | a7ea7912cfc9d0da7989fafd04ab99c55577a37d /mcs/class/Microsoft.Build/Test | |
| parent | d16a01fe9801feba249b2aacbc350cc4f030ba42 (diff) | |
Use ";" not Empty as bad TargetFrameworkDirectory value
After manager.Build is called, a "null" empty for TargetFrameworkDirectory is
a string containing only ";" - a "good" value is the target framework
directory with a trailing ";". By testing for string.Empty, we don't actually
test whether the value has been correctly populated (causing all subsequent
failures).
Diffstat (limited to 'mcs/class/Microsoft.Build/Test')
| -rw-r--r-- | mcs/class/Microsoft.Build/Test/Microsoft.Build.Execution/BuildManagerTest.cs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mcs/class/Microsoft.Build/Test/Microsoft.Build.Execution/BuildManagerTest.cs b/mcs/class/Microsoft.Build/Test/Microsoft.Build.Execution/BuildManagerTest.cs index cdf6e9f2c32..9f0b2aceda8 100644 --- a/mcs/class/Microsoft.Build/Test/Microsoft.Build.Execution/BuildManagerTest.cs +++ b/mcs/class/Microsoft.Build/Test/Microsoft.Build.Execution/BuildManagerTest.cs @@ -183,7 +183,7 @@ namespace MonoTests.Microsoft.Build.Execution var request = new BuildRequestData (proj, new string [] {"ResolveAssemblyReferences"}); Assert.AreEqual (string.Empty, proj.GetPropertyValue ("TargetFrameworkDirectory"), "#1-1"); var result = manager.Build (parameters, request); - Assert.AreNotEqual (string.Empty, proj.GetPropertyValue ("TargetFrameworkDirectory"), "#1-2"); // filled during build. + Assert.AreNotEqual (";", proj.GetPropertyValue ("TargetFrameworkDirectory"), "#1-2"); // filled during build. Assert.IsTrue (result.ResultsByTarget.ContainsKey ("GetFrameworkPaths"), "#2-1"); Assert.IsTrue (result.ResultsByTarget.ContainsKey ("PrepareForBuild"), "#2-2"); Assert.IsTrue (result.ResultsByTarget.ContainsKey ("ResolveAssemblyReferences"), "#2-3"); |